(diff) ← Older revision | Latest revision (diff) | Newer revision → (diff)
[11:07 AM] Ubit Umarov: welcome to opensimulator meeting andrew
[11:07 AM] Andrew Hellershanks: Hello
[11:07 AM] Andrew Hellershanks: Thanks. Seem to be a few of the regulars that aren't here yet.
[11:08 AM] Ubit Umarov: seems we wil not have many ppl today
[11:08 AM] Andrew Hellershanks: I was delayed due to a work call.
[11:08 AM] Ubit Umarov: joe was here already, telling he is lost on IRL taxes work
[11:08 AM] Ubit Umarov: lyr may not came also
[11:09 AM] Ubit Umarov: nad ofc those lazy opensim devs did nothing last week
[11:09 AM] Andrew Hellershanks: Yes, it is tax season. :P
[11:10 AM] Ubit Umarov: yeah i will need to start to think abotu that also..
[11:10 AM] Vincent.Sylvester @hg.zetaworlds.com: You did some cosmetics
[11:11 AM] Vincent.Sylvester @hg.zetaworlds.com: I was and am busy with the search nonsense
[11:14 AM] Vincent.Sylvester @hg.zetaworlds.com: I got this curious case of the viewer sending 4 search requests when you login, but does not send a regionhandle, which I assume is meant to indicate "current region", but they determining the region they are in from just the IClientAPI is a bit of a pain
[11:15 AM] Vincent.Sylvester @hg.zetaworlds.com: I make that assumption based on the return handling looking specifically for whether the returned region data matches any of the scenes it knows
[11:16 AM] Vincent.Sylvester @hg.zetaworlds.com: So either the server end determines what to send based on matching the IP and port of the request to the registered regions or I have to do this in the module based on the agent id
[11:17 AM] Andrew Hellershanks: Hello, Cuga.
[11:17 AM] Vincent.Sylvester @hg.zetaworlds.com: I rewrote these requests on both sides to send them as what they are map item requests, to simplify the handling on the server end since it only really needs to know the type, but I guess I'll have to send the region as well after finding the right one
[11:17 AM] Ubit Umarov: oh you are right ... i did soem cosmetics
[11:17 AM] Ubit Umarov: but those do not count much as devel
[11:18 AM] Ubit Umarov: if (uac is null) return 0; return uac.UserFlags;
[11:18 AM] Ubit Umarov: versus
[11:18 AM] Ubit Umarov: return uac is null ? 0 : uac.UserFlags;
[11:18 AM] Ubit Umarov: is even same code after compiler first steps
[11:18 AM] Andrew Hellershanks: Both work. Not sure which I prefer. For myself, I would likely do it using an if.
[11:19 AM] Vincent.Sylvester @hg.zetaworlds.com: Well that at least is somewhat readable, some of the other sugar visual studio suggests is downright criminal
[11:19 AM] Ubit Umarov: well ? : is some cases is more compact
[11:19 AM] Ubit Umarov: but fisrt thing compiler does it convert it to the if
[11:20 AM] Ubit Umarov: lookAt = "[r0.99949799999999999756,r0.03166859999999999814,r0]";
[11:20 AM] Ubit Umarov: lookAt = "[r1,r0,r0]";
[11:20 AM] Ubit Umarov: is basilcly a cleanup
[11:21 AM] Ubit Umarov: etc
[11:21 AM] Vincent.Sylvester @hg.zetaworlds.com: Like example: return ["Command help: "+((CommandInfo)value).help_text]; to me is a readability nightmare
[11:23 AM] Ubit Umarov: yeah return new string[] {"Command help: "+((CommandInfo)value).help_text} is a lot better
[11:23 AM] Ubit Umarov: ( hihihihi )
[11:23 AM] Vincent.Sylvester @hg.zetaworlds.com: Both versions are awful, but with one of them can at least tell what the heck it is returning
[11:24 AM] Ubit Umarov: but yeah use of [ ] is part of new cosmetics also
[11:24 AM] Vincent.Sylvester @hg.zetaworlds.com: return [new List<string>(current.Keys)[0]]; wtf is the type on that
[11:24 AM] Vincent.Sylvester @hg.zetaworlds.com: Spoiler, it's also a string array
[11:24 AM] Ubit Umarov: sounds like object[]
[11:25 AM] Ubit Umarov: a list inside a string[] ?
[11:25 AM] Vincent.Sylvester @hg.zetaworlds.com: Yeah that's my worry in some of these cases, cause we have seen that with the .Split confusing chars
[11:25 AM] Ubit Umarov: err nm it is [0] of the list
[11:25 AM] Ubit Umarov: so yeah string
[11:26 AM] Vincent.Sylvester @hg.zetaworlds.com: return new string[] { new List<string>(current.Keys)[0] }; is the current version
[11:26 AM] Vincent.Sylvester @hg.zetaworlds.com: I mean it works, I won't complain, changing that carries a lot more rewriting with it
[11:26 AM] Ubit Umarov: odd
[11:26 AM] Ubit Umarov: that looks odd
[11:27 AM] Vincent.Sylvester @hg.zetaworlds.com: Looking at the file history it starts to make sense :P
[11:28 AM] Vincent.Sylvester @hg.zetaworlds.com: I ran the code check on the entire codebase, came back with 18000 suggestions
[11:29 AM] Andrew Hellershanks: That will take you a day or three to work through all those suggestions. :)
[11:29 AM] Vincent.Sylvester @hg.zetaworlds.com: It also really makes visual studio slow af
[11:29 AM] Vincent.Sylvester @hg.zetaworlds.com: Would not recommend
[11:29 AM] Vincent.Sylvester @hg.zetaworlds.com: A lot of it was also things like naming and code quality nonsense
[11:29 AM] Ubit Umarov: that code does not make much sense
[11:30 AM] Ubit Umarov: hope it not mine
[11:30 AM] Ubit Umarov: it is not...
[11:30 AM] Vincent.Sylvester @hg.zetaworlds.com: Usual suspects
[11:30 AM] Vincent.Sylvester @hg.zetaworlds.com: Not many come up with art like that
[11:31 AM] Vincent.Sylvester @hg.zetaworlds.com: That said I was in there trying to figure out how to extend command handling and hit a brick wall so now I made 24 commands instead of a single one
[11:31 AM] Ubit Umarov: well get first element on a dic is undefined..
[11:31 AM] Ubit Umarov: dic have no order
[11:31 AM] Ubit Umarov: that code will get anything
[11:32 AM] Vincent.Sylvester @hg.zetaworlds.com: I think at that point it might only contain a single item
[11:32 AM] Vincent.Sylvester @hg.zetaworlds.com: Doesn't make it better I know
[11:32 AM] Vincent.Sylvester @hg.zetaworlds.com: But changing that cascades into a lot of code
[11:33 AM] Ubit Umarov: oh nooo it maybe my code... lol
[11:35 AM] Vincent.Sylvester @hg.zetaworlds.com: Well you can have fun fixing that, I got search to wrangle into submission
[11:35 AM] Ubit Umarov: nopes there in 2013 already
[11:40 AM] Ubit Umarov: 2009 even
[11:40 AM] Vincent.Sylvester @hg.zetaworlds.com: Speaking of search there were some updates to the interface in viewers, which promptly broke the websearch tab. Been trying to figure out how that's even broken cause all the code looks fine and reading the correct thing yet displays the wrong url
[11:41 AM] Vincent.Sylvester @hg.zetaworlds.com: At least it looks a bit more organized now
[11:42 AM] Vincent.Sylvester @hg.zetaworlds.com: I was hoping to add the categories to the lists, but apparently there are no provisions in the packets to send that data for the listview, only the detailed info queries so unless I add that to the end for backwards compatibility not gonna happen unfortunately
[11:42 AM] Vincent.Sylvester @hg.zetaworlds.com: How that was initially omitted is beyond me
[11:43 AM] Vincent.Sylvester @hg.zetaworlds.com: Logic not the strong point when it comes to protocol design, what else is new with LL -.-
[11:45 AM] Andrew Hellershanks: :)
[11:57 AM] Ubit Umarov: ahh there is dino
[11:59 AM] Ubit Umarov: `wel any other issue?
[12:07 PM] Ubit Umarov: well rl calls
[12:07 PM] Ubit Umarov: hope you have a nice week, and to see you all next week, if not before
