[Opensim-dev] Wholesale reformatting of files

[James Hughes]

It appears to be 625452b84baf68775454209fd2d3198f138762f2 .
c3138f9f38420ae370078df3b0990a953f43b087 has massive changes as well,
but I think the main one is 625452b. See
OpenSim/Region/Framework/Scenes/Scene.cs


Thanks,
-BlueWall

On Wed, 2015-05-27 at 18:23 +0200, Melanie wrote:
> Could you please point out the commit this happened is, as I don't
> see it? Or is this still in Mantis?
> 
> - Melanie
> 
> On 27/05/2015 03:00, James Hughes wrote:
> > The last round of patches from MOSES team reformatted Scene.cs removing
> > intentions after constructs like: if, foreach, etc. if there is only one
> > line following. I have not seen other code like this in OpenSimulator,
> > and it doesn't fit any coding conventions I have seen for C#. Also,
> > Wholesale formatting of huge files makes it nearly impossible to see
> > what changes were actually made to the file. And finally these cause
> > unnecessary merge conflicts in private branches.
> > 
> > I would like to see these removed from the last round of files and make
> > sure that all commits contain only essential changes and constructs
> > follow commonly used C# coding style. If it is absolutely necessary to
> > re-format a file, that is all that should be committed and the commit
> > message should indicate that.
> > 
> > Thanks,
> > -James
> > BlueWall
> > 
> > _______________________________________________
> > Opensim-dev mailing list
> > Opensim-dev at opensimulator.org
> > http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev
> > 
> > 
> _______________________________________________
> Opensim-dev mailing list
> Opensim-dev at opensimulator.org
> http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev