[Opensim-dev] Wholesale reformatting of files

Melanie melanie at t-data.com
Wed May 27 16:23:45 UTC 2015


Could you please point out the commit this happened is, as I don't
see it? Or is this still in Mantis?

- Melanie

On 27/05/2015 03:00, James Hughes wrote:
> The last round of patches from MOSES team reformatted Scene.cs removing
> intentions after constructs like: if, foreach, etc. if there is only one
> line following. I have not seen other code like this in OpenSimulator,
> and it doesn't fit any coding conventions I have seen for C#. Also,
> Wholesale formatting of huge files makes it nearly impossible to see
> what changes were actually made to the file. And finally these cause
> unnecessary merge conflicts in private branches.
> 
> I would like to see these removed from the last round of files and make
> sure that all commits contain only essential changes and constructs
> follow commonly used C# coding style. If it is absolutely necessary to
> re-format a file, that is all that should be committed and the commit
> message should indicate that.
> 
> Thanks,
> -James
> BlueWall
> 
> _______________________________________________
> Opensim-dev mailing list
> Opensim-dev at opensimulator.org
> http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev
> 
> 


More information about the Opensim-dev mailing list