[Opensim-dev] Wholesale reformatting of files

James Hughes jamesh at bluewallgroup.com
Wed May 27 01:00:33 UTC 2015


The last round of patches from MOSES team reformatted Scene.cs removing
intentions after constructs like: if, foreach, etc. if there is only one
line following. I have not seen other code like this in OpenSimulator,
and it doesn't fit any coding conventions I have seen for C#. Also,
Wholesale formatting of huge files makes it nearly impossible to see
what changes were actually made to the file. And finally these cause
unnecessary merge conflicts in private branches.

I would like to see these removed from the last round of files and make
sure that all commits contain only essential changes and constructs
follow commonly used C# coding style. If it is absolutely necessary to
re-format a file, that is all that should be committed and the commit
message should indicate that.

Thanks,
-James
BlueWall



More information about the Opensim-dev mailing list