[Opensim-dev] Wholesale reformatting of files (UNCLASSIFIED)

[Maxwell, Douglas CIV USARMY ARL (US)]

Classification: UNCLASSIFIED
Caveats: NONE

As a rule, we are adhering to the coding standards of the target project.
In this case our guide is here:
http://opensimulator.org/wiki/Coding_standards

Our team has been correcting any improperly formatted code as we come across
it.  We are finding a lot of mismatched formatting and we believed we were
doing your community a service by performing these corrections as we spotted
them.

If these standards are no longer a part of your standard operating
procedures, please update your coding standards documentation and we will
adjust accordingly.

Thank you for your comment.

v/r -doug

Douglas Maxwell
Science and Technology Manager
Virtual World Strategic Applications
U.S. Army Research Lab
Simulation & Training Technology Center (STTC)
(c) (407) 242-0209



-----Original Message-----
From: opensim-dev-bounces at opensimulator.org
[mailto:opensim-dev-bounces at opensimulator.org] On Behalf Of James Hughes
Sent: Tuesday, May 26, 2015 9:01 PM
To: OpenSim Developers
Subject: [Opensim-dev] Wholesale reformatting of files

The last round of patches from MOSES team reformatted Scene.cs removing
intentions after constructs like: if, foreach, etc. if there is only one
line following. I have not seen other code like this in OpenSimulator, and
it doesn't fit any coding conventions I have seen for C#. Also, Wholesale
formatting of huge files makes it nearly impossible to see what changes were
actually made to the file. And finally these cause unnecessary merge
conflicts in private branches.

I would like to see these removed from the last round of files and make sure
that all commits contain only essential changes and constructs follow
commonly used C# coding style. If it is absolutely necessary to re-format a
file, that is all that should be committed and the commit message should
indicate that.

Thanks,
-James
BlueWall

_______________________________________________
Opensim-dev mailing list
Opensim-dev at opensimulator.org
http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev

Classification: UNCLASSIFIED
Caveats: NONE


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5629 bytes
Desc: not available
URL: <http://opensimulator.org/pipermail/opensim-dev/attachments/20150528/eaecee21/attachment.bin>