[Opensim-dev] [Opensim-commits] r5988 - trunk/OpenSim/Region/Environment/Modules/InterGrid

[Teravus Ovares]

I added them in the planning stage..     but instead of doing complicated
conversions, I changed the units when they came in to OpenSimulator.  Seems
to work well.   People do seem to understand X*256,Y*256 better then x,y and
you have to ensure that it's a multiple of 256.   Though, I still plan on
having the unit option.   So, the ones that are not in use are safe to
delete.

Best Regards

Teravus


On 8/26/08, Justin Clark-Casey <jjustincc at googlemail.com> wrote:
>
> Sean Dague wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > justincc at opensimulator.org wrote:
> >> Author: justincc
> >> Date: 2008-08-25 16:32:06 -0700 (Mon, 25 Aug 2008)
> >> New Revision: 5988
> >>
> >> Modified:
>
> >>    trunk/OpenSim/Region/Environment/Modules/InterGrid/OpenGridProtocolModule.cs
> >> Log:
> >> * minor: zap some more compilation warnings
> >>
> >>
> >> Modified:
> trunk/OpenSim/Region/Environment/Modules/InterGrid/OpenGridProtocolModule.cs
> >> ===================================================================
> >> ---
> trunk/OpenSim/Region/Environment/Modules/InterGrid/OpenGridProtocolModule.cs
> 2008-08-25 23:31:50 UTC (rev 5987)
> >> +++
> trunk/OpenSim/Region/Environment/Modules/InterGrid/OpenGridProtocolModule.cs
> 2008-08-25 23:32:06 UTC (rev 5988)
> >> @@ -735,10 +735,10 @@
> >>              return Util.UIntsToLong(reg.RegionLocX, reg.RegionLocY);
> >>          }
> >>
> >> -        private ulong GetOSCompatibleRegionHandle(uint x, uint y)
> >> -        {
> >> -            return Util.UIntsToLong(x, y);
> >> -        }
> >> +//        private ulong GetOSCompatibleRegionHandle(uint x, uint y)
> >> +//        {
> >> +//            return Util.UIntsToLong(x, y);
> >> +//        }
> >>
> >>  //        private ulong GetOSCompatibleRegionHandle(ulong regionhandle)
> >>  //        {
> >> @@ -753,10 +753,10 @@
> >>  //            return Util.UIntsToLong((reg.RegionLocX *
> (uint)Constants.RegionSize), (reg.RegionLocY * (uint)Constants.RegionSize));
> >>  //        }
> >>
> >> -        private ulong GetOGPCompatibleRegionHandle(uint x, uint y)
> >> -        {
> >> -            return Util.UIntsToLong((x * (uint)Constants.RegionSize),
> (y * (uint)Constants.RegionSize));
> >> -        }
> >> +//        private ulong GetOGPCompatibleRegionHandle(uint x, uint y)
> >> +//        {
> >> +//            return Util.UIntsToLong((x * (uint)Constants.RegionSize),
> (y * (uint)Constants.RegionSize));
> >> +//        }
> >
> > Can these be deleted instead of commented out?  It would be good to get
> > rid of them if they aren't used any more, just to keep our cruft levels
> > down.
>
> Well, unless one is familiar with the code, it's entirely possible that
> these are imminently going to be used, so commenting out seems more
> constructive than just deleting them.
>
> Personally, if I travel through a section of code with such commented
> out stuff and I know that nobody has looked at it for a while, I will
> then actually delete them at that later date.
>
> >
> >       -Sean
> >
> > - --
> > Sean Dague / Neas Bade
> > sdague at gmail.com
> > http://dague.net
> >
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v1.4.6 (GNU/Linux)
> > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
> >
> > iD8DBQFIs3pASamXem9TdyYRAplIAJ4uq1nTlMA9hMVqUWKllf0KPJ2eEACZAYzo
> > a/vmAnDG2WR8P0zfw870NVY=
> > =o/Gi
> > -----END PGP SIGNATURE-----
> > _______________________________________________
> > Opensim-dev mailing list
> > Opensim-dev at lists.berlios.de
> > https://lists.berlios.de/mailman/listinfo/opensim-dev
> >
>
>
> --
> justincc
> Justin Clark-Casey
> http://justincc.wordpress.com
> _______________________________________________
> Opensim-dev mailing list
> Opensim-dev at lists.berlios.de
> https://lists.berlios.de/mailman/listinfo/opensim-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://opensimulator.org/pipermail/opensim-dev/attachments/20080826/577d4849/attachment-0001.html>