<div>I added them in the planning stage.. but instead of doing complicated conversions, I changed the units when they came in to OpenSimulator. Seems to work well. People do seem to understand X*256,Y*256 better then x,y and you have to ensure that it's a multiple of 256. Though, I still plan on having the unit option. So, the ones that are not in use are safe to delete.</div>
<div> </div>
<div>Best Regards</div>
<div> </div>
<div>Teravus<br><br> </div>
<div><span class="gmail_quote">On 8/26/08, <b class="gmail_sendername">Justin Clark-Casey</b> <<a href="mailto:jjustincc@googlemail.com">jjustincc@googlemail.com</a>> wrote:</span>
<blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">Sean Dague wrote:<br>> -----BEGIN PGP SIGNED MESSAGE-----<br>> Hash: SHA1<br>><br>> <a href="mailto:justincc@opensimulator.org">justincc@opensimulator.org</a> wrote:<br>
>> Author: justincc<br>>> Date: 2008-08-25 16:32:06 -0700 (Mon, 25 Aug 2008)<br>>> New Revision: 5988<br>>><br>>> Modified:<br>>> trunk/OpenSim/Region/Environment/Modules/InterGrid/OpenGridProtocolModule.cs<br>
>> Log:<br>>> * minor: zap some more compilation warnings<br>>><br>>><br>>> Modified: trunk/OpenSim/Region/Environment/Modules/InterGrid/OpenGridProtocolModule.cs<br>>> ===================================================================<br>
>> --- trunk/OpenSim/Region/Environment/Modules/InterGrid/OpenGridProtocolModule.cs 2008-08-25 23:31:50 UTC (rev 5987)<br>>> +++ trunk/OpenSim/Region/Environment/Modules/InterGrid/OpenGridProtocolModule.cs 2008-08-25 23:32:06 UTC (rev 5988)<br>
>> @@ -735,10 +735,10 @@<br>>> return Util.UIntsToLong(reg.RegionLocX, reg.RegionLocY);<br>>> }<br>>><br>>> - private ulong GetOSCompatibleRegionHandle(uint x, uint y)<br>
>> - {<br>>> - return Util.UIntsToLong(x, y);<br>>> - }<br>>> +// private ulong GetOSCompatibleRegionHandle(uint x, uint y)<br>>> +// {<br>>> +// return Util.UIntsToLong(x, y);<br>
>> +// }<br>>><br>>> // private ulong GetOSCompatibleRegionHandle(ulong regionhandle)<br>>> // {<br>>> @@ -753,10 +753,10 @@<br>>> // return Util.UIntsToLong((reg.RegionLocX * (uint)Constants.RegionSize), (reg.RegionLocY * (uint)Constants.RegionSize));<br>
>> // }<br>>><br>>> - private ulong GetOGPCompatibleRegionHandle(uint x, uint y)<br>>> - {<br>>> - return Util.UIntsToLong((x * (uint)Constants.RegionSize), (y * (uint)Constants.RegionSize));<br>
>> - }<br>>> +// private ulong GetOGPCompatibleRegionHandle(uint x, uint y)<br>>> +// {<br>>> +// return Util.UIntsToLong((x * (uint)Constants.RegionSize), (y * (uint)Constants.RegionSize));<br>
>> +// }<br>><br>> Can these be deleted instead of commented out? It would be good to get<br>> rid of them if they aren't used any more, just to keep our cruft levels<br>> down.<br><br>Well, unless one is familiar with the code, it's entirely possible that<br>
these are imminently going to be used, so commenting out seems more<br>constructive than just deleting them.<br><br>Personally, if I travel through a section of code with such commented<br>out stuff and I know that nobody has looked at it for a while, I will<br>
then actually delete them at that later date.<br><br>><br>> -Sean<br>><br>> - --<br>> Sean Dague / Neas Bade<br>> <a href="mailto:sdague@gmail.com">sdague@gmail.com</a><br>> <a href="http://dague.net">http://dague.net</a><br>
><br>> -----BEGIN PGP SIGNATURE-----<br>> Version: GnuPG v1.4.6 (GNU/Linux)<br>> Comment: Using GnuPG with Mozilla - <a href="http://enigmail.mozdev.org">http://enigmail.mozdev.org</a><br>><br>> iD8DBQFIs3pASamXem9TdyYRAplIAJ4uq1nTlMA9hMVqUWKllf0KPJ2eEACZAYzo<br>
> a/vmAnDG2WR8P0zfw870NVY=<br>> =o/Gi<br>> -----END PGP SIGNATURE-----<br>> _______________________________________________<br>> Opensim-dev mailing list<br>> <a href="mailto:Opensim-dev@lists.berlios.de">Opensim-dev@lists.berlios.de</a><br>
> <a href="https://lists.berlios.de/mailman/listinfo/opensim-dev">https://lists.berlios.de/mailman/listinfo/opensim-dev</a><br>><br><br><br>--<br>justincc<br>Justin Clark-Casey<br><a href="http://justincc.wordpress.com">http://justincc.wordpress.com</a><br>
_______________________________________________<br>Opensim-dev mailing list<br><a href="mailto:Opensim-dev@lists.berlios.de">Opensim-dev@lists.berlios.de</a><br><a href="https://lists.berlios.de/mailman/listinfo/opensim-dev">https://lists.berlios.de/mailman/listinfo/opensim-dev</a><br>
</blockquote></div><br>