[Opensim-dev] Warning Safari (was Re: Current Status of OpenSim Git Master)

Sat Nov 21 20:04:25 UTC 2015

I think it also needs to be pointed out that fixing warnings in windows may
be creating new warnings for Linux users, most of our developers are using
Linux environment and developing with Mono not microsoft .net.  While
things may appear to be improving for some, for other its making the
situation worse potentially.  Just a heads up.  cross platform is hard and
stuff!

On Sat, Nov 21, 2015 at 2:22 PM, AJLDuarte <ajlduarte at sapo.pt> wrote:

> Hi Tom,
>         OpenSim master branch is not a "production" version. So the code in
> production in Avination is not in sync with opensim master.
>         That’s why a merge was needed and started on a branch, so normal
> work on master could go on.
>         We just started the next step, Avination code contribution is now
> on
> master and a larger community can help debugging.
>         We may have issues that resulted from that merge adding to old
> master issues.
>
> Regards,
> Ubit.
>
> -----Original Message-----
> From: opensim-dev-bounces at opensimulator.org
> [mailto:opensim-dev-bounces at opensimulator.org] On Behalf Of Tom Frost
> Sent: Saturday, November 21, 2015 18:23
> To: opensim-dev at opensimulator.org
> Subject: Re: [Opensim-dev] Warning Safari (was Re: Current Status of
> OpenSim
> Git Master)
>
> Hi,
>
> On Sat, Nov 21, 2015 at 04:42:00PM +0100, Melanie IMAP wrote:
> > I gave you the OK for a warning safari but I believed you understood that
> this is alpha code.
>
> I was under the impression that the avination merge was complete (as per
> Diva's email from 16 november), so i was under the impression the code for
> the avination features was done. I also thought the code was in use in
> production in avination, so I assumed it would be of production quality.
> Sorry I misunderstood.
>
> > I would like for you to continue, but please take these things to heart:
> >
> > - Unused variables, including those assigned to but not used, can only be
> commented, not removed. In many cases you will find that the values
> ganerated are used in debugging statements further down that have been
> commented!
>
> I'm a little hesistant now to even comment them - as that would only lead
> to
> a patch that will be largely reverted anyway.
>
> > - Commented code needs to be left where it is. Also,  a warning safari is
> not a mandate to beautify code. No reordering and no whitespace corrections
> should be done.
> >
> > Limited code cleanup or whitespace correction can be done outside the
> warning safari and after it's complete.
> >
> > The issue here is that whitespace changes break pulling from git for
> downstream projects needlessly. So does code reordering, etc.
>
> I shall wait until the new avination code is more mature, and leave things
> alone for now. Please close the mantis issue for now. I'll lurk on this
> list
> to see when things become more mature.
>
> > Regarding the team, we are a multinational team and not all of us have
> English as their first language or America as their cultural origin. Please
> do feel free to approach people about perceived slights, but let's not make
> a big deal out of a wording. What counts is the spirit, not the letter.
>
> My first language is not English and I don't have America as my cultural
> origin.
>
> - Tom
>
> >
> > - Melanie
> >
> > On 21 Nov 2015, at 10:14, Tom Frost <tomfrost at linkwater.org> wrote:
> >
> > Hi opensim devs,
> >
> > > On Fri, Nov 20, 2015 at 11:50:09PM +0100, Tom Frost wrote:
> > >> On Fri, Nov 20, 2015 at 02:33:53PM +0100, Melanie wrote:
> > >> a warning safari is highly appreciated. You don't need to create a
> > >> Mantis for each warning, simply create one for the warnings and
> > >> attach the patches to it. For pure warning removal with no
> > >> functional changes, the patches can be larger than what we usually
> > >> ask for with functional changes.
> > >
> > > Alright, i've gone ahead and created this issue:
> > >
> > > http://opensimulator.org/mantis/view.php?id=7746
> > >
> > > and attached 13 patches to address a first batch of low-hanging
> > > fruit. I thought it would be convenient for picking which ones to
> > > apply.. But I can resubmit it as one large path if that is
> > > preferred. Just let me know!
> >
> > ---+ Unused variables and warnings
> >
> > I got this response:
> >
> > 'Hi, thanks but please stop for now :( You are also removing comments,
> > dead code, etc, and that needs to be checked case by case, even some
> > unused variables are there waiting future use You removed for example
> > debug messages that we put back every time we need.  I can't apply
> > patches like this automatically. I will use them as reference.  I did
> > remove a few of those warnings, increasing the total reported by 2 ;)´
> >
> > Unused variables that are there waiting for future use and that
> > generate warnings are in violation with the coding standards as stated
> > on http://opensimulator.org/wiki/Coding_standards:
> >
> > "Warnings
> >
> >    Please keep the code warning free, using #pragma only if absolutely
> > necessary. For instance ..."
> >
> > Are all the core devs aligned in the acceptance of the practice of
> > leaving in unused variables that generate warnings during compilation
> > because someone at some point may want to use them?
> >
> > If so, please rewrite the coding standards, so that new people like me
> > don't waste their time.
> >
> > ---+ Debug statements and commented-out code
> >
> > I'm ok with redoing the patches to leave in large fragments of
> > commented-out code and stray debug log statements that have been
> > commented out (if indeed all core devs are fine with the ugliness this
> > introduces into the codebase).
> >
> > As for debug statements, wouldn't it be better to define them as such
> > by not commenting them out but leaving them in and make them
> > conditional on a variable that configures the debug level of logging?
> >
> > ---+ Bad attitude
> >
> > As a sidenote, telling someone to 'please stop for now :(' is not very
> > productive. If I need to do things differently just say so, instead of
> > using discouraging wording. From the comment above it feels like my
> > work is not appreciated and i should not attempt to help out.
> >
> >
> >
> > Please let me know how to proceed.
> >
> > Thanks,
> >
> > Tom
> > _______________________________________________
> > Opensim-dev mailing list
> > Opensim-dev at opensimulator.org
> > http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev
> > _______________________________________________
> > Opensim-dev mailing list
> > Opensim-dev at opensimulator.org
> > http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev
> >
> _______________________________________________
> Opensim-dev mailing list
> Opensim-dev at opensimulator.org
> http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev
>
> _______________________________________________
> Opensim-dev mailing list
> Opensim-dev at opensimulator.org
> http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev
>

-- 
Michael Emory Cerquoni
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://opensimulator.org/pipermail/opensim-dev/attachments/20151121/b2a01dff/attachment.html>