[Opensim-dev] Wholesale reformatting of files (UNCLASSIFIED)

[James Hughes]

You are asking us to take your contributions, please have a little
courtesy and help us maintain our standards by making sure your
submitted work is properly done. We are not able to do massive work to
fix such things. I started to make fixes myself until I saw how massive
the problem is. 

--BlueWall 


On Thu, 2015-05-28 at 19:40 +0000, Maxwell, Douglas CIV USARMY ARL (US)
wrote:
> Classification: UNCLASSIFIED
> Caveats: NONE
> 
> Just tell us how you want it done and we'd be happy to oblige.  Let's keep
> perspective here, we are working on some pretty hard problems on your
> behalf.  Harping on us over indents and spaces seems a bit petty.
> 
> v/r -doug
> 
> Douglas Maxwell
> Science and Technology Manager
> Virtual World Strategic Applications
> U.S. Army Research Lab
> Simulation & Training Technology Center (STTC)
> (c) (407) 242-0209
> 
> 
> 
> -----Original Message-----
> From: opensim-dev-bounces at opensimulator.org
> [mailto:opensim-dev-bounces at opensimulator.org] On Behalf Of Melanie
> Sent: Thursday, May 28, 2015 3:28 PM
> To: opensim-dev at opensimulator.org
> Subject: Re: [Opensim-dev] Wholesale reformatting of files (UNCLASSIFIED)
> 
> That could happen if hardtabs are used. OpenSim's standard is 4-space soft
> tabs. If indentation was removed or hardtabs introduced, that would need to
> be reversed.
> 
> - Melanie
> 
> On 28/05/2015 21:21, Cinder Roxley wrote:
> > On May 28, 2015 at 12:54:11 PM, Maxwell, Douglas CIV USARMY ARL (US)
> (douglas.maxwell3.civ at mail.mil) wrote:
> > Classification: UNCLASSIFIED
> > Caveats: NONE
> > 
> > As a rule, we are adhering to the coding standards of the target project. 
> > In this case our guide is here: 
> > http://opensimulator.org/wiki/Coding_standards
> > 
> > Our team has been correcting any improperly formatted code as we come 
> > across it. We are finding a lot of mismatched formatting and we 
> > believed we were doing your community a service by performing these 
> > corrections as we spotted them.
> > 
> > If these standards are no longer a part of your standard operating 
> > procedures, please update your coding standards documentation and we 
> > will adjust accordingly.
> > 
> > Thank you for your comment. 
> > 
> > v/r -doug
> > 
> > 
> > Hi,
> > 
> > I assume he was referring to the areas that were changed which do *not*
> conform to either the opensim coding standing or any coding standard I've
> ever seen where indentation was removed making the code much harder to grok
> such as:
> > 
> > https://github.com/opensim/opensim/blob/master/OpenSim/Region/Framewor
> > k/Scenes/Scene.cs#L3820
> > https://github.com/opensim/opensim/blob/master/OpenSim/Region/Framewor
> > k/Scenes/Scene.cs#L4469
> > https://github.com/opensim/opensim/blob/master/OpenSim/Region/Framewor
> > k/Scenes/Scene.cs#L4472
> > 
> > and various other places scattered about throughout Scene.cs between
> revisions c3138f9 and 625452b. It seems a lot of unbracketed single
> statement if blocks, even multi-lined ones, had their indentation stripped
> off. This is not a normal convention is any language I know of.
> > 
> > --
> > Cinder Roxley
> > Sent with Airmail
> > 
> > 
> > 
> > _______________________________________________
> > Opensim-dev mailing list
> > Opensim-dev at opensimulator.org
> > http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev
> _______________________________________________
> Opensim-dev mailing list
> Opensim-dev at opensimulator.org
> http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev
> 
> Classification: UNCLASSIFIED
> Caveats: NONE
> 
> 
> _______________________________________________
> Opensim-dev mailing list
> Opensim-dev at opensimulator.org
> http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev