[Opensim-dev] ICSharpCpde.SharpZipLib.dll

[Heilmann, Michael]

The MOSES devs did not modify that file.  You can see at https://github.com/M-O-S-E-S/opensim/commits/master/bin/ICSharpCode.SharpZipLib.dll that the only modification we have for that file in our repository is when Diva added it on Dec 29, 2014.  The hash in question doesn't even exist on our repository as we haven't updated our public github from opensim/master since then.  You can revert that file if it is problematic without it affecting our changes.

Our most recent patch was problematic.  The changes we had made had conflicts in the history, and a straight patch was not working.  Melanie and nebadon were working with us in IRC, but we could not change our merge to a rebase after the fact to generate the desired patch.  Melanie ended up just pulling from our repository instead of working with the squashed patch in order to maintain commit history.  The file may have been picked up during that pull/merge process.

Michael Heilmann

________________________________________
From: opensim-dev-bounces at opensimulator.org <opensim-dev-bounces at opensimulator.org> on behalf of Ai Austin <ai.ai.austin at gmail.com>
Sent: Thursday, June 11, 2015 9:35 AM
To: opensim-dev at opensimulator.org
Subject: Re: [Opensim-dev] ICSharpCpde.SharpZipLib.dll

At 13:00 11/06/2015, Dahlia Trimble  wrote:
>May want to check to see if that library is still used anywhere. Only
>places I know that use zip/zlib/whatever are mesh decompression, materials,
>and iar/oar save/load, but there may be others. I remember I changed mesh
>decompression to use System.IO.Compression probably a year or more ago. so
>it shouldn't be needed there unless someone else changed it back.

Modules mentioning zlib is definitely still used... but I am not sure
if this comes from SharpZipLib.dll. I see decompression errors for
most mesh regions where Warp3D map tile rendering is enabled...

e.g.

2015-06-10 09:02:21,655 DEBUG -
OpenSim.Region.CoreModules.World.WorldMap.WorldMapModule [WORLD MAP]:
Generating map image for Black Rock

2015-06-10 09:02:24,968 ERROR - OpenMetaverse Failed to decode mesh asset
ComponentAce.Compression.Libs.zlib.ZStreamException: inflating:
    at ComponentAce.Compression.Libs.zlib.ZOutputStream.Write(Byte[]
b1, Int32 off, Int32 len)
    at OpenMetaverse.Helpers.CopyStream(Stream input, Stream output)
    at OpenMetaverse.Helpers.ZDecompressOSD(Byte[] data)
    at OpenMetaverse.Assets.AssetMesh.Decode()

http://opensimulator.org/mantis/view.php?id=7020


_______________________________________________
Opensim-dev mailing list
Opensim-dev at opensimulator.org
http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev