[Opensim-dev] Restructuring test directories
Justin Clark-Casey
jjustincc at googlemail.com
Fri Sep 5 23:17:45 UTC 2008
Dahlia Trimble wrote:
> Personally I think good tests are a great idea, but I do think they
> should be available and functioning properly on all recommended
> development platforms prior to becoming mandatory for commit. In my
> case some tests were added or modified in a commit prior to mine that
> had nothing to do with the code I had committed, but it caused 2 build
> failures that were counted against me. In this case I think the method
> for collecting developer statistics is misleading at best and should
> be remedied or abandoned. Unit tests are great if they lead to a
> higher quality product, but if they are implemented in a haphazard
> manner they could serve to lower contributor productivity and motivation.
Hey Dahlia. Although, of course, like all of us I try to take care not
to break the build and fix it when it does break, I wouldn't pay too
much attention to those statistics - we're not going to tar and feather
the person with the highest number :-) (which might actually be me...)
Although I did half suggest previous that we could attach the name of
the commiter associated with a build break to the irc output, this was a
bit stupid on my part since we're all in this together and not looking
to pin blame on anybody (so maybe just the revision number instead). I
hope that when a test failure occurs we'll all look to help fix it just
as we do a build break.
>
> I'm definitely willing to work with those who have different
> development environments than I to help them get the tests they
> implement working in my environment, and I hope the converse is true
> as well. Likewise I would be hesitant to enforce any tests that I may
> add for my code unless I had some assurance that the tests were
> functional and usable by all core developers. Perhaps we need some
> sort of qualification for the unit tests themselves before they can be
> enforced against any commit process.
Cool. From Adam's other post, it sounds like the way forward is just to
convert the @ defined strings in CSCodeGenerator.cs to concatenated
strings with explicit embedded newlines instead.
--
justincc
>
>
>
> On Fri, Sep 5, 2008 at 2:38 PM, Justin Clark-Casey
> <jjustincc at googlemail.com <mailto:jjustincc at googlemail.com>> wrote:
>
> Dickson, Mike (ISS Software) wrote:
> > Not doing any serious development on OpenSIM at present (though
> working to come up to speed to do so). I strongly agree with
> Melanie here though. Tests may pull in dependencies that are
> unneeded in the production code.
> >
> > IMO, tests only get maintained when developers commit to
> maintaining them. I'm sure we've all seen cases where test code is
> way out of date even though its located with or in the same file
> with an implementation.
> >
> We run the tests on every build. I'm hoping to post the results
> to the
> IRC channel and other places, and I hope that this will be enough
> of an
> imperative to keep them passing. I'll also probably start bugging
> people if they don't get fixed up.
>
> If any of the core developers don't think that this is a good idea and
> wouldn't be prepared to fix up tests that break (with reasonable
> exceptions, of course), please say so and we can discuss it now.
>
> Regards,
>
> justincc
> > Mike
> >
> > -----Original Message-----
> > From: opensim-dev-bounces at lists.berlios.de
> <mailto:opensim-dev-bounces at lists.berlios.de>
> [mailto:opensim-dev-bounces at lists.berlios.de
> <mailto:opensim-dev-bounces at lists.berlios.de>] On Behalf Of Melanie
> > Sent: Friday, September 05, 2008 9:45 AM
> > To: opensim-dev at lists.berlios.de
> <mailto:opensim-dev at lists.berlios.de>
> > Subject: Re: [Opensim-dev] Restructuring test directories
> >
> > IMHO, the tests belong in separate DLLs. Especially in the case of
> > the script engines including them in the main assembly is to be
> > avoided at all cost, as they pull deps in behind them and use up
> > space in the already cramped appdomains. That code needs to remain
> > lean and free of code not needed to do the job. Having the tests in
> > memory at all times causes bloat.
> >
> > Melanie
> >
> >
> > Sean Dague wrote:
> >
> >> Melanie wrote:
> >>
> >>> Hi,
> >>>
> >>> because of the way prebuild works, the tests would then be
> compiled
> >>> into them ain assembly. That is not what we want.
> >>>
> >> So, I'm confused as to why we wouldn't want the tests in the main
> >> assemblies. OpenSim.Region.Environment already does this, and
> it seems
> >> way saner than seperate trees for tests, and it much more
> likely to keep
> >> those tests up to date and relevant.
> >>
> >> -Sean
> >>
> >>
> >>
> >>
> ------------------------------------------------------------------------
> >>
> >> _______________________________________________
> >> Opensim-dev mailing list
> >> Opensim-dev at lists.berlios.de <mailto:Opensim-dev at lists.berlios.de>
> >> https://lists.berlios.de/mailman/listinfo/opensim-dev
> >>
> > _______________________________________________
> > Opensim-dev mailing list
> > Opensim-dev at lists.berlios.de <mailto:Opensim-dev at lists.berlios.de>
> > https://lists.berlios.de/mailman/listinfo/opensim-dev
> > _______________________________________________
> > Opensim-dev mailing list
> > Opensim-dev at lists.berlios.de <mailto:Opensim-dev at lists.berlios.de>
> > https://lists.berlios.de/mailman/listinfo/opensim-dev
> >
> >
>
> _______________________________________________
> Opensim-dev mailing list
> Opensim-dev at lists.berlios.de <mailto:Opensim-dev at lists.berlios.de>
> https://lists.berlios.de/mailman/listinfo/opensim-dev
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Opensim-dev mailing list
> Opensim-dev at lists.berlios.de
> https://lists.berlios.de/mailman/listinfo/opensim-dev
>
More information about the Opensim-dev
mailing list