[Opensim-dev] On Mantis #1370 (avatar persistence)

[Sean Dague]

On Tue, Jun 10, 2008 at 01:39:41AM +0900, liu xiaolu wrote:
> My personal suggestion:
> 
> For getting apprearance data:
> remove the 2nd "if" condition in "TryGetAvatarAppearance".
> >>> if ((profile != null) && (profile.RootFolder != null))  --> if (profile
> != null)
> remove "SetAppearanceAssets" in "TryGetAvatarAppearance".
> >>> // SetAppearanceAssets(profile, ref appearance);
> 
> For storing would be almost the same.

Can you pull together a patch like that and test it on grid mode?  (make
sure to clear the caches between tests).

> >This was added to deal with the "Can't find your clothes" issue.
> It seems that this is the reason why "RootFolder" information is needed.
> I think it is not necessary (or should not) to check assetID's avaliability
> by using C# code.
> It is a tired, buggy way to go, even you can make "getinventory"
> synchronous.
> Both of the MySQL, MSSQL have the native support of "FOREGIN KEY
> constaints".
> RDBMS should handle such task for us.

SQLite doesn't handle it natively, and we've not really used foreign
keys anywhere else in the design up till this point.

> THEN,
> in that case, ... Table "inventoryfolders", "inventoryitems",
> "avatarappearance" should be always in the save DB. ...
> THEN,
> probably, getapearance should be moved to inventoryservice :>
> 
> It is very strange that you get appearance from use server and then check
> them by using the information from inventory server. these things
> can(should) be done in one request.

I don't think any of this would get any better if you changed the back
end service.  If johan is right, and it's a service timing issue, then
that's what really needs to be addressed.

    -Sean

-- 
__________________________________________________________________

Sean Dague                                       Mid-Hudson Valley
sean at dague dot net                            Linux Users Group
http://dague.net                                 http://mhvlug.org

There is no silver bullet.  Plus, werewolves make better neighbors
than zombies, and they tend to keep the vampire population down.
__________________________________________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://opensimulator.org/pipermail/opensim-dev/attachments/20080609/2c629e9e/attachment-0001.pgp>