[Opensim-dev] Archiver issues

Sat Jul 26 21:42:18 UTC 2008

Uhh..?

I took a look at this code, and it seems rather confused at the moment; the PhysActor code in AbsolutePosition is commented out (r5668) so I don't see what would actually trigger an update of the physics with the new position?
the set = get currently seem to do two things:

1) it does a bounds control, to see if the prim should cross borders (which is way out of line for a property to be doing)
and
2) if triggers a copying of the GroupPosition out to the Child Parts.

Both these behaviours should be refactored out into separate methods, and the AbsolutePosition property should be split into at least two methods, one for position data manipulation - that won't do physics and boundaries, but will dirty the object, and one for moving an object (MoveObjectToPosition or something) - that will do both.
Again, we have some confusion arising from the fact that we have no clear separation between data objects (that can be counted on to be passive) and controlled objects (that can be counted on to propagate change thru the system)
Best regards,Stefan AnderssonTribal Media AB Join the 3d web revolution : http://tribalnet.se/ 

Date: Sat, 26 Jul 2008 13:50:32 -0700From: dahliatrimble at gmail.comTo: opensim-dev at lists.berlios.deSubject: Re: [Opensim-dev] Archiver issues
Changing it so only HasGroupChanged = false; is commented out seems to work for physics. I'm not familiar with the archiving so I cant test it. I made this change and committed it as of r5668, so could anyone else can test the archiving part in that version?Anyone with insight care to comment on what AbsolutePosition = AbsolutePosition; does and why it is necessary?
On Sat, Jul 26, 2008 at 4:18 AM, Justin Clark-Casey <jjustincc at googlemail.com> wrote:

Dahlia Trimble wrote:> Sadly I had to revert a portion of r5659 as it was wreaking havok with> the meshing at sim startup. I'm not sure but it may also have been> related to prims not appearing in the viewer after crossing into a> region. I'm not familiar with the archiving so I don't know how to test> whether it's broken again, but I suspect it's adversely affected.>> The part I had to reinstate was ResetChildPrimPhysicsPositions() in> SceneObjectGroup.csHi Dahlia.  As you know, there are only two statements inResetChildPrimPhysicsPositions().        public void ResetChildPrimPhysicsPositions()        {            AbsolutePosition = AbsolutePosition;            HasGroupChanged = false;        }Is there any chance you could tell me whether the problem is caused bythe lack of AbsolutePosition = AbsolutePosition (which is a bizarrelooking thing but does have an actual effect), or HasGroupChanged = false;If it's the AbsolutePosition statement that is important , then theHasGroupChanged can be simply commented out to get archiving workingproperly again.  If it's the HasGroupChanged that is important than Ineed to go and look at the code more closely.Thanks muchly.justincc
>> -d>> On Fri, Jul 25, 2008 at 2:53 PM, Frisby, Adam <adam at deepthink.com.au
> <mailto:adam at deepthink.com.au>> wrote:>>     Just a confirmation, this did indeed fix the issue. Thanks.>>     Adam>>      > -----Original Message----->      > From: opensim-dev-bounces at lists.berlios.de
>     <mailto:opensim-dev-bounces at lists.berlios.de> [mailto:opensim-dev->     <mailto:opensim-dev->
>      > bounces at lists.berlios.de <mailto:bounces at lists.berlios.de>] On>     Behalf Of Justin Clark-Casey>      > Sent: Friday, 25 July 2008 11:06 AM>      > To: opensim-dev at lists.berlios.de

>     <mailto:opensim-dev at lists.berlios.de>>      > Subject: Re: [Opensim-dev] Archiver issues>      >>      > Sean Dague wrote:>      > > On Fri, Jul 25, 2008 at 11:48:14AM +0100, Justin Clark-Casey wrote:>      > > <snip>>      > >> Yeah, there are problems in this area (hence the big 'highly>      > experimental' signs, but I'm sure everyone is aware of that>      > >> ;-).  The archive file would be very helpful for analysis if you>      > could>      > >> make that request for me.>      > >>      > > Working on something related, we found that restoring a large>     number>      > of>      > > items to Scene very quickly overruns the script event queue, as all>      > the>      > > events are fired all at once, and can't be processed fast enough.>      >>      > Yep, I think I've seen the same thing on an archive reload,>     though none>      > of my current files appear>      > to do it.>      >>      > >>      > > I'm not sure if this is the same issue or not, but it might be>      > related.>      >>      > It is unrelated, but if anybody has an example archive where the>     script>      > reload problem happens I>      > would be very happy to take a look at it.>      >>      > -->      > justincc>      > Justin Clark-Casey>      > http://justincc.wordpress.com>      > _______________________________________________>      > Opensim-dev mailing list>      > Opensim-dev at lists.berlios.de <mailto:Opensim-dev at lists.berlios.de>
>      > https://lists.berlios.de/mailman/listinfo/opensim-dev>     _______________________________________________>     Opensim-dev mailing list>     Opensim-dev at lists.berlios.de <mailto:Opensim-dev at lists.berlios.de>
>     https://lists.berlios.de/mailman/listinfo/opensim-dev>>>> ------------------------------------------------------------------------>> _______________________________________________> Opensim-dev mailing list> Opensim-dev at lists.berlios.de> https://lists.berlios.de/mailman/listinfo/opensim-dev--

justinccJustin Clark-Caseyhttp://justincc.wordpress.com_______________________________________________Opensim-dev mailing listOpensim-dev at lists.berlios.dehttps://lists.berlios.de/mailman/listinfo/opensim-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://opensimulator.org/pipermail/opensim-dev/attachments/20080726/d751a46f/attachment-0001.html>