<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#FF0000" bgcolor="#FFFFFF">
For unused variables it's better to comment the lines, ending them
by a comment like:<br>
// the line of unused code; //Warning's Safari 20151121 1115<br>
<br>
<span id="result_box" class="" lang="en"><span class="hps">The
commented</span> <span class="hps">lines of code</span> <span
class="hps">are not to be</span> <span class="hps">removed</span>
<span class="hps">especially with this</span> <span class="hps">new
version of the</span> <span class="hps">master</span><span>;</span>
<span class="hps">they are used</span> <span class="hps">to</span>
<span class="hps">debug</span> <span class="hps">when something</span>
<span class="hps">regresses</span><span>.</span> <span
class="hps">But it should be</span> <span class="hps">the
responsibility of the</span> <span class="hps">developer</span>
<span class="hps">to date these</span> <span class="hps">lines</span>
<span class="hps">to differentiate</span> <span class="hps">very
old</span> <span class="hps">comments</span> <span class="hps">which</span>
<span class="hps">are useless</span><span>.<br>
</span></span><br>
<span id="result_box" class="" lang="en"><span class="hps">Can I</span>
<span class="hps">draw your attention to</span> <span class="hps">certain
warnings</span> <span class="hps">that</span> <span
class="hps">I have long ago</span> <span class="hps">and for
which</span> <span class="hps">I did</span> <span class="hps">not
find any</span> <span class="hps">explanations</span><span>?<br>
(the code </span></span><span id="result_box" class=""
lang="en"><span><span id="result_box" class="" lang="en"><span
class="hps">is</span> <span class="hps">compiled</span> <span
class="hps">under</span> <span class="hps">Windows 10</span>
<span class="hps">with C #</span> <span class="hps">Express
2010)</span></span></span></span><br>
<span id="result_box" class="" lang="en"><span><span id="result_box"
class="" lang="en"><span class="hps"><span id="result_box"
class="" lang="en"><span class="hps">Warning</span> <span
class="hps atn">11 '</span><span>2008'</span> <span
class="hps">is not</span> <span class="hps">a valid</span>
<span class="hps">warning</span> <span class="hps">number</span>
<span class="hps">OpenSim.Data<br>
or<br>
</span></span></span></span></span></span><span
id="result_box" class="" lang="en"><span class="hps">Warning</span>
<span class="hps atn">61 '</span><span>2008'</span> <span
class="hps">is not</span> <span class="hps">a valid</span> <span
class="hps">warning</span> <span class="hps">number</span> <span
class="hps">OpenSim.Region.ScriptEngine.XEngine.Api.Runtime<br>
<br>
</span></span><span id="result_box" class="" lang="en"><span
class="hps"><span id="result_box" class="" lang="en"><span
class="hps">There are</span> <span class="hps">15</span> <span
class="hps">to</span> <span class="hps">40</span> <span
class="hps">warnings</span> <span class="hps">such as</span>
<span class="hps">those</span> <span class="hps alt-edited">according
to </span><span class="hps">the</span> master <span
class="hps">compiled.</span><span class=""><br>
</span></span></span></span><span id="result_box"
class="short_text" lang="en"><span class="hps"><span
id="result_box" class="" lang="en"><span class="hps">Do</span>
<span class="hps">you see</span> <span class="hps">these
warnings</span> <span class="hps">and what</span> <span
class="hps">it means</span> <span class="hps">in '2008</span><span>'?<br>
<br>
GL<br>
</span></span></span><span class="hps"><br>
</span></span>
<div class="moz-cite-prefix">Le 21/11/2015 10:14, Tom Frost a
écrit :<br>
</div>
<blockquote cite="mid:20151121091440.GA3178@sunra" type="cite">
<pre wrap="">Hi opensim devs,
On Fri, Nov 20, 2015 at 11:50:09PM +0100, Tom Frost wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On Fri, Nov 20, 2015 at 02:33:53PM +0100, Melanie wrote:
</pre>
<blockquote type="cite">
<pre wrap="">a warning safari is highly appreciated. You don't need to create a
Mantis for each warning, simply create one for the warnings and
attach the patches to it. For pure warning removal with no
functional changes, the patches can be larger than what we usually
ask for with functional changes.
</pre>
</blockquote>
<pre wrap="">
Alright, i've gone ahead and created this issue:
<a class="moz-txt-link-freetext" href="http://opensimulator.org/mantis/view.php?id=7746">http://opensimulator.org/mantis/view.php?id=7746</a>
and attached 13 patches to address a first batch of low-hanging
fruit. I thought it would be convenient for picking which ones
to apply.. But I can resubmit it as one large path if that
is preferred. Just let me know!
</pre>
</blockquote>
<pre wrap="">
---+ Unused variables and warnings
I got this response:
'Hi, thanks but please stop for now :( You are also removing comments, dead code,
etc, and that needs to be checked case by case, even some unused variables are
there waiting future use You removed for example debug messages that we put back every time we
need. I can't apply patches like this automatically. I will use them as
reference. I did remove a few of those warnings, increasing the total reported by 2
;)´
Unused variables that are there waiting for future use and that
generate warnings are in violation with the coding standards as stated
on <a class="moz-txt-link-freetext" href="http://opensimulator.org/wiki/Coding_standards">http://opensimulator.org/wiki/Coding_standards</a>:
"Warnings
Please keep the code warning free, using #pragma only if absolutely
necessary. For instance ..."
Are all the core devs aligned in the acceptance of the practice of
leaving in unused variables that generate warnings during compilation
because someone at some point may want to use them?
If so, please rewrite the coding standards, so that new people like me
don't waste their time.
---+ Debug statements and commented-out code
I'm ok with redoing the patches to leave in large fragments of
commented-out code and stray debug log statements that have been
commented out (if indeed all core devs are fine with the ugliness this
introduces into the codebase).
As for debug statements, wouldn't it be better to define them as such by
not commenting them out but leaving them in and make them conditional on
a variable that configures the debug level of logging?
---+ Bad attitude
As a sidenote, telling someone to 'please stop for now :(' is not very
productive. If I need to do things differently just say so, instead of
using discouraging wording. From the comment above it feels like my work
is not appreciated and i should not attempt to help out.
Please let me know how to proceed.
Thanks,
Tom
_______________________________________________
Opensim-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Opensim-dev@opensimulator.org">Opensim-dev@opensimulator.org</a>
<a class="moz-txt-link-freetext" href="http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev">http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev</a>
</pre>
</blockquote>
</body>
</html>