
<html><head><style>body{font-family:Helvetica,Arial;font-size:13px}</style></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">On May 28, 2015 at 12:54:11 PM, Maxwell, Douglas CIV USARMY ARL (US) (<a href="mailto:douglas.maxwell3.civ@mail.mil">douglas.maxwell3.civ@mail.mil</a>) wrote:</div> <div><div><blockquote type="cite" class="clean_bq" style="color: rgb(0, 0, 0); font-family: Helvetica, Arial; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><span><div><div></div><div>Classification: UNCLASSIFIED<span class="Apple-converted-space"> </span><br>Caveats: NONE<span class="Apple-converted-space"> </span><br><br>As a rule, we are adhering to the coding standards of the target project.<span class="Apple-converted-space"> </span><br>In this case our guide is here:<span class="Apple-converted-space"> </span><br>http://opensimulator.org/wiki/Coding_standards<span class="Apple-converted-space"> </span><br><br>Our team has been correcting any improperly formatted code as we come across<span class="Apple-converted-space"> </span><br>it. We are finding a lot of mismatched formatting and we believed we were<span class="Apple-converted-space"> </span><br>doing your community a service by performing these corrections as we spotted<span class="Apple-converted-space"> </span><br>them.<span class="Apple-converted-space"> </span><br><br>If these standards are no longer a part of your standard operating<span class="Apple-converted-space"> </span><br>procedures, please update your coding standards documentation and we will<span class="Apple-converted-space"> </span><br>adjust accordingly.<span class="Apple-converted-space"> </span><br><br>Thank you for your comment.<span class="Apple-converted-space"> </span><br><br>v/r -doug</div></div></span></blockquote></div><p><br></p></div><div id="bloop_customfont" style="margin: 0px;">Hi,</div><div id="bloop_customfont" style="margin: 0px;"><br></div><div id="bloop_customfont" style="margin: 0px;">I assume he was referring to the areas that were changed which do *not* conform to either the opensim coding standing or any coding standard I’ve ever seen where indentation was removed making the code much harder to grok such as:</div><div id="bloop_customfont" style="margin: 0px;"><br></div><div id="bloop_customfont" style="margin: 0px;"><a href="https://github.com/opensim/opensim/blob/master/OpenSim/Region/Framework/Scenes/Scene.cs#L3820">https://github.com/opensim/opensim/blob/master/OpenSim/Region/Framework/Scenes/Scene.cs#L3820</a></div><div id="bloop_customfont" style="margin: 0px;"><a href="https://github.com/opensim/opensim/blob/master/OpenSim/Region/Framework/Scenes/Scene.cs#L4469">https://github.com/opensim/opensim/blob/master/OpenSim/Region/Framework/Scenes/Scene.cs#L4469</a></div><div id="bloop_customfont" style="margin: 0px;"><a href="https://github.com/opensim/opensim/blob/master/OpenSim/Region/Framework/Scenes/Scene.cs#L4472">https://github.com/opensim/opensim/blob/master/OpenSim/Region/Framework/Scenes/Scene.cs#L4472</a></div><div id="bloop_customfont" style="margin: 0px;"><br></div><div id="bloop_customfont" style="margin: 0px;">and various other places scattered about throughout Scene.cs between revisions <span style="font-family: Helvetica;">c3138f9 and </span><font face="Helvetica">625452b. It seems a lot of unbracketed single statement if blocks, even multi-lined ones, had their indentation stripped off. This is not a normal convention is any language I know of.</font></div><div id="bloop_customfont" style="margin: 0px;"><span style="font-family: Helvetica;"><br></span></div><div id="bloop_sign_1432840150177020928" class="bloop_sign"><div style="font-family: helvetica, arial;">-- <br>Cinder Roxley<br>Sent with Airmail</div></div></body></html>