<div dir="ltr">Personally I think good tests are a great idea, but I do think they should be available and functioning properly on all recommended development platforms prior to becoming mandatory for commit. In my case some tests were added or modified in a commit prior to mine that had nothing to do with the code I had committed, but it caused 2 build failures that were counted against me. In this case I think the method for collecting developer statistics is misleading at best and should be remedied or abandoned. Unit tests are great if they lead to a higher quality product, but if they are implemented in a haphazard manner they could serve to lower contributor productivity and motivation.<div>
<br></div><div>I'm definitely willing to work with those who have different development environments than I to help them get the tests they implement working in my environment, and I hope the converse is true as well. Likewise I would be hesitant to enforce any tests that I may add for my code unless I had some assurance that the tests were functional and usable by all core developers. Perhaps we need some sort of qualification for the unit tests themselves before they can be enforced against any commit process.<br>
<br></div><div><br></div><div><br><div class="gmail_quote">On Fri, Sep 5, 2008 at 2:38 PM, Justin Clark-Casey <span dir="ltr"><<a href="mailto:jjustincc@googlemail.com">jjustincc@googlemail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div class="Ih2E3d">Dickson, Mike (ISS Software) wrote:<br>
> Not doing any serious development on OpenSIM at present (though working to come up to speed to do so). I strongly agree with Melanie here though. Tests may pull in dependencies that are unneeded in the production code.<br>
><br>
> IMO, tests only get maintained when developers commit to maintaining them. I'm sure we've all seen cases where test code is way out of date even though its located with or in the same file with an implementation.<br>
><br>
</div>We run the tests on every build. I'm hoping to post the results to the<br>
IRC channel and other places, and I hope that this will be enough of an<br>
imperative to keep them passing. I'll also probably start bugging<br>
people if they don't get fixed up.<br>
<br>
If any of the core developers don't think that this is a good idea and<br>
wouldn't be prepared to fix up tests that break (with reasonable<br>
exceptions, of course), please say so and we can discuss it now.<br>
<br>
Regards,<br>
<br>
justincc<br>
<div><div></div><div class="Wj3C7c">> Mike<br>
><br>
> -----Original Message-----<br>
> From: <a href="mailto:opensim-dev-bounces@lists.berlios.de">opensim-dev-bounces@lists.berlios.de</a> [mailto:<a href="mailto:opensim-dev-bounces@lists.berlios.de">opensim-dev-bounces@lists.berlios.de</a>] On Behalf Of Melanie<br>
> Sent: Friday, September 05, 2008 9:45 AM<br>
> To: <a href="mailto:opensim-dev@lists.berlios.de">opensim-dev@lists.berlios.de</a><br>
> Subject: Re: [Opensim-dev] Restructuring test directories<br>
><br>
> IMHO, the tests belong in separate DLLs. Especially in the case of<br>
> the script engines including them in the main assembly is to be<br>
> avoided at all cost, as they pull deps in behind them and use up<br>
> space in the already cramped appdomains. That code needs to remain<br>
> lean and free of code not needed to do the job. Having the tests in<br>
> memory at all times causes bloat.<br>
><br>
> Melanie<br>
><br>
><br>
> Sean Dague wrote:<br>
><br>
>> Melanie wrote:<br>
>><br>
>>> Hi,<br>
>>><br>
>>> because of the way prebuild works, the tests would then be compiled<br>
>>> into them ain assembly. That is not what we want.<br>
>>><br>
>> So, I'm confused as to why we wouldn't want the tests in the main<br>
>> assemblies. OpenSim.Region.Environment already does this, and it seems<br>
>> way saner than seperate trees for tests, and it much more likely to keep<br>
>> those tests up to date and relevant.<br>
>><br>
>> -Sean<br>
>><br>
>><br>
>><br>
>> ------------------------------------------------------------------------<br>
>><br>
>> _______________________________________________<br>
>> Opensim-dev mailing list<br>
>> <a href="mailto:Opensim-dev@lists.berlios.de">Opensim-dev@lists.berlios.de</a><br>
>> <a href="https://lists.berlios.de/mailman/listinfo/opensim-dev" target="_blank">https://lists.berlios.de/mailman/listinfo/opensim-dev</a><br>
>><br>
> _______________________________________________<br>
> Opensim-dev mailing list<br>
> <a href="mailto:Opensim-dev@lists.berlios.de">Opensim-dev@lists.berlios.de</a><br>
> <a href="https://lists.berlios.de/mailman/listinfo/opensim-dev" target="_blank">https://lists.berlios.de/mailman/listinfo/opensim-dev</a><br>
> _______________________________________________<br>
> Opensim-dev mailing list<br>
> <a href="mailto:Opensim-dev@lists.berlios.de">Opensim-dev@lists.berlios.de</a><br>
> <a href="https://lists.berlios.de/mailman/listinfo/opensim-dev" target="_blank">https://lists.berlios.de/mailman/listinfo/opensim-dev</a><br>
><br>
><br>
<br>
_______________________________________________<br>
Opensim-dev mailing list<br>
<a href="mailto:Opensim-dev@lists.berlios.de">Opensim-dev@lists.berlios.de</a><br>
<a href="https://lists.berlios.de/mailman/listinfo/opensim-dev" target="_blank">https://lists.berlios.de/mailman/listinfo/opensim-dev</a><br>
</div></div></blockquote></div><br></div></div>