[Opensim-dev] Wholesale reformatting of files (UNCLASSIFIED)

[Dahlia Trimble]

Adding formatting and other corrections which are unrelated to the
functionality of the patch increases the noise in the patch when deltas are
viewed in patch review and revision control tools. A few lines of
formatting change are probably acceptable as long as they are a lesser
portion of the patch, however if they are the majority it makes patch
review and future debugging much more difficult and increases the
likelihood that critical changes may be missed or obscured. Therefore
functionality and formatting should be separate patches.

On Thu, May 28, 2015 at 12:28 PM, Melanie <melanie at t-data.com> wrote:

> That could happen if hardtabs are used. OpenSim's standard is
> 4-space soft tabs. If indentation was removed or hardtabs
> introduced, that would need to be reversed.
>
> - Melanie
>
> On 28/05/2015 21:21, Cinder Roxley wrote:
> > On May 28, 2015 at 12:54:11 PM, Maxwell, Douglas CIV USARMY ARL (US) (
> douglas.maxwell3.civ at mail.mil) wrote:
> > Classification: UNCLASSIFIED
> > Caveats: NONE
> >
> > As a rule, we are adhering to the coding standards of the target project.
> > In this case our guide is here:
> > http://opensimulator.org/wiki/Coding_standards
> >
> > Our team has been correcting any improperly formatted code as we come
> across
> > it. We are finding a lot of mismatched formatting and we believed we were
> > doing your community a service by performing these corrections as we
> spotted
> > them.
> >
> > If these standards are no longer a part of your standard operating
> > procedures, please update your coding standards documentation and we will
> > adjust accordingly.
> >
> > Thank you for your comment.
> >
> > v/r -doug
> >
> >
> > Hi,
> >
> > I assume he was referring to the areas that were changed which do *not*
> conform to either the opensim coding standing or any coding standard I’ve
> ever seen where indentation was removed making the code much harder to grok
> such as:
> >
> >
> https://github.com/opensim/opensim/blob/master/OpenSim/Region/Framework/Scenes/Scene.cs#L3820
> >
> https://github.com/opensim/opensim/blob/master/OpenSim/Region/Framework/Scenes/Scene.cs#L4469
> >
> https://github.com/opensim/opensim/blob/master/OpenSim/Region/Framework/Scenes/Scene.cs#L4472
> >
> > and various other places scattered about throughout Scene.cs between
> revisions c3138f9 and 625452b. It seems a lot of unbracketed single
> statement if blocks, even multi-lined ones, had their indentation stripped
> off. This is not a normal convention is any language I know of.
> >
> > --
> > Cinder Roxley
> > Sent with Airmail
> >
> >
> >
> > _______________________________________________
> > Opensim-dev mailing list
> > Opensim-dev at opensimulator.org
> > http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev
> _______________________________________________
> Opensim-dev mailing list
> Opensim-dev at opensimulator.org
> http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://opensimulator.org/pipermail/opensim-dev/attachments/20150528/7dbf698a/attachment.html>