[Opensim-dev] Folder numbers

[Cinder Roxley]

I think it would be a good idea to leave a comment line in both structures 
to say why there is no longer an entry for 9. State it is a deprecated value? 

Is the value of 9 used for anything in Second Life? 
Type 9 was deprecated in Second Life in late 2009 and the commit message states that it was never used.

"EXT-2482 : Newly created folders have wrong default type

Removed AT_ROOT_CATEGORY and FT_ROOT_CATEGORY since those types are unused. Changed FT_CATEGORY to FT_ROOT_INVENTORY to make its purpose more clear.

This change assumes that no agent inventories have category type 9 for either inventory type or folder preferred type.”

It appears that when the asset type enum was added to libomv, AT_ROOT_CATEGORY still existed, though unused. Linden Lab removed it due to confusion; they were creating wrong folders with it. They apparently were doing exactly the same thing as libomv. ;)

And imo, leaving comments about removed code around is unnecessary. That’s what a revision history is for.

-- 
Cinder Roxley
Sent with Airmail
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://opensimulator.org/pipermail/opensim-dev/attachments/20150809/63ab0f8b/attachment-0001.html>