[Opensim-dev] Folder numbers

[Cinder Roxley]

On August 6, 2015 at 8:52:21 AM, Oren Hurvitz (orenh at kitely.com) wrote:
+1 to changing the root folder type to 8.

Regarding the Suitcase Folder: in the database, the Folder Type is 100. This unique value is used to find the suitcase folder. However, viewers don't understand this type, so when we send the folder to them we pretend that its type is 8. These constants are defined at the top of InventoryItemBase.cs. IIRC you (Diva) had defined this constant, and the commit I had made was just to make sure it's used in *every* place where we talk to the viewer, as some places were sending folder type 8 and some were sending folder type -1.

If the viewer devs add support for Folder Type 100 then we could remove the hack that sends a fake type for the suitcase. However, this would have to be delayed until we can be sure that most of the OpenSim users have upgraded to viewers that support this.

I believe using folder type -1 for the Suitcase caused problems, which is why I took the time to make sure we never send it. IIRC there were two problems, both of which are caused by the fact that folder type -1 is normally used for user-created folders, but we want the Suitcase folder to behave like a system folder (like the folders "Objects", "Textures", etc.)

The first problem is that the Suitcase folder becomes deletable if its type is -1. I don't remember what happens if you try to delete it and the server refuses: it may be that the folder appears deleted in the viewer but reappears later. But that still "astonishes the user". The second problem is that the folder gets dumped with the rest of the user-created folders (in the sort order), where it may not be easily visible. Currently, when it has a System Folder Type (anything other than -1), it gets sorted with the system folders.

So the best approach is this: first, we'll switch the folder types: send the Root Folder as 8, and the Suitcase as 9. Once the viewer devs have added support for Folder Type 100, and enough time has passed that most users have such viewers, we'll change the folder type of the Suitcase to 100, and the viewer devs will remove the hacks that they currently use for OpenSim.

Oren
That sounds reasonable. I’m going to add FT_SUITCASE to our upcoming release and send patches out to Firestorm and Singularity with the changes for integration. I had some janky suitcase folder detection based on folder name and parent, but this will be much better. :) Only time will tell how long it takes for users to adopt the updates.

-- 
Cinder Roxley
Sent with Airmail
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://opensimulator.org/pipermail/opensim-dev/attachments/20150806/746ae6e9/attachment-0001.html>