[Opensim-dev] MOSES Patch 3 (UNCLASSIFIED)

[Maxwell, Douglas CIV USARMY ARL (US)]

Classification: UNCLASSIFIED
Caveats: NONE

The MOSES Team recently released a patch containing the final set of performance metrics to the OpenSim Mantis. The patch modified and introduced metrics that measure the simulator’s network performance. The contents of the patch have been discussed in other threads.

After satisfying all of the security and preferred configuration options recommended by Melanie, Ai Austin, and Bruce, we have produced a patch that we were confident would be accepted without issue. Unfortunately, our latest patch received heavy trivial and inconsistent criticism that was subjective and atypical; none of the issues identified counter the OpenSim standards. Below is a list of the issues listed on our Mantis ticket:

1.  Decompose the patch into multiple, smaller patches.

2.  Inconsistent terminology in the configuration file comments.

3.  Provide a Wiki entry detailing the metrics.

4.  Why is there a master On/Off switch when each metric has its own On/Off switch?

5.  Comments are too long and convoluted.

6.  “AgentAddressPort” should not be located in the new, independent Advanced Network Metrics ini file, but in the main OpenSim.ini.

7.  Change the configuration variable name from "Include-AdvancedMetricsEnable" to "Include-AdvancedMetrics."

8.  “Number of logging in users” is too specific to MOSES.

9.  Metrics that deal with packets should have “packets” in the name.

10. Excessive line-breaks in the source code.

11. The patch notes contain white space warnings that must be resolved (these are Git warnings, not compiler warnings).

The Moses Team has taken the initiative to devote resources and time in adding to the development of OpenSim. This work in particular has corrected invalid metrics and introduced necessary ones to fully evaluate the simulator’s performance at any time. Yes, this patch, just like our two previously accepted patches, contains a lot of work but size was necessary because many of the network metrics are co-dependent (code-wise) and it does not make any sense to split up the commits. Additionally, our patches have been decomposed into 3 categorized phases; this is our final patch that only contains network related statistics.

Moving forward, we are submitting a new patch in two days. The patch resolves one unit test failure that we discovered and one spelling mistake (an instance of “of” instead of “off”).  We hope that this upcoming patch is accepted into core without incident. We also hope that any nonessential issues from here on out be resolved by opening up a separate ticket instead of holding up an entire effort of development.

On behalf of the MOSES team, respectfully - doug

Douglas Maxwell
Science and Technology Manager
Virtual World Strategic Applications
U.S. Army Research Lab
Simulation & Training Technology Center (STTC)
(c) (407) 242-0209

Classification: UNCLASSIFIED
Caveats: NONE


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5629 bytes
Desc: not available
URL: <http://opensimulator.org/pipermail/opensim-dev/attachments/20150803/24ebe5e7/attachment-0001.bin>