[Opensim-dev] SQLite doen't need Community.CsharpSqlite.dll?

[Teravus Ovares]

I know this is old, however I wanted to mention that it is a SQLite
implementation in managed C# code for cases where using the native DLL
sqlite was impossible.   To test it properly you would have had to
enable it and run the tests.    I suspect it's not really being used
now except by maybe embedded users if at all so it's not that big of a
deal...    No worries.

That said, the 'reason' for ripping it out was simply warnings...
which is no reason at all for ripping out functionality.    Which, I
generally disapprove of.    Suggestions, before ripping code out, it
should be better understood what you're ripping out and why. :).   Had
you said the reason was 'lack of documentation', or some other valid
reason for ripping out that bit of code, I would be happier :)

Regards

Teravus

On Wed, Apr 23, 2014 at 12:32 PM, Justin Clark-Casey
<jjustincc at googlemail.com> wrote:
> afair, CSharpSQLite was something that Teravus was experimenting with for
> SQLite support that we did not end up using. So yes, it's quite correct to
> remove it.
>
>
> On 22/04/14 18:28, Melanie wrote:
>>
>> If OpenSim will compile and run on all supported platforms without
>> it, then it's not needed and can be dropped. In that case the binary
>> should also be removed from bin/
>>
>> - Melanie
>>
>> On 22/04/2014 18:55, Oren Hurvitz wrote:
>>>
>>> I'm working on eliminating warnings. A few of the warnings had to do with
>>> SQLite (the precise warnings aren't important, but they had to do with a
>>> DLL that reimplements System.Func). I found that I can eliminate the
>>> warnings if I remove the following lines from prebuild.xml:
>>>
>>>        <Reference name="Community.CsharpSqlite" path="../../../bin/"/>
>>>        <Reference name="Community.CsharpSqlite.Sqlite"
>>> path="../../../bin"/>
>>>
>>> This doesn't seem to have broken SQLite, because I ran the unit tests
>>> afterwards (which use SQLite), and they still ran fine.
>>>
>>> By the way, the second of these two lines was *already* in error: because
>>> there's no backslash after "bin", the resulting reference was invalid.
>>>
>>> Does anyone know of a reason why these references should stay?
>>>
>>> Oren
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> Opensim-dev mailing list
>>> Opensim-dev at opensimulator.org
>>> http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev
>>
>> _______________________________________________
>> Opensim-dev mailing list
>> Opensim-dev at opensimulator.org
>> http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev
>>
>
>
> --
> Justin Clark-Casey (justincc)
> OSVW Consulting
> http://justincc.org
> http://twitter.com/justincc
>
> _______________________________________________
> Opensim-dev mailing list
> Opensim-dev at opensimulator.org
> http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev