[Opensim-dev] Fix OSSL threat level checks

[Justin Clark-Casey]

The NPC issues were indeed a mistake and I have corrected these in git master eced091

I also believe osParseJSONNew() should also be checked separately.  I can see a scenario where you might want to allow 
one function but not the other (e.g. because the newer one is more efficient/better).  And this would eliminate 
confusing inconsistency with everything else.

I can definitely see a case for being able to control groups of functions (e.g. npc).  But I think if this is to be 
implemented it should be with a CheckThreatLevel overload with an extra category parameter if/when necessary, leaving 
the existing CheckThreatLevel function in place.

On 13/04/12 12:49, Melanie wrote:
> I know with the JSON function it was intentional. As for the Npc
> one, I don't know. Justin, can you enlighten us? Copy/Paste error or
> good intention?
>
> Melanie
>
> On 13/04/2012 11:59, Oren Hurvitz wrote:
>> Hi,
>>
>> There are two OSSL functions that check the wrong string for their threat
>> level:
>>
>> osParseJSONNew() - checks "osParseJSON"
>> osNpcStopMoveToTarget() - checks "osNpcStopMoveTo"
>>
>> I was going to fix this, but then I thought that perhaps this was done so
>> that the same threat level can be used for "families" of functions, e.g.
>> both osParseJSON() and osParseJSONNew(). So is it ok to change these
>> strings, or should I leave them alone?
>>
>> Oren
>>
>>
>> --
>> View this message in context: http://opensim-dev.2196679.n2.nabble.com/Fix-OSSL-threat-level-checks-tp7462134p7462134.html
>> Sent from the opensim-dev mailing list archive at Nabble.com.
>> _______________________________________________
>> Opensim-dev mailing list
>> Opensim-dev at lists.berlios.de
>> https://lists.berlios.de/mailman/listinfo/opensim-dev
>>
>>
> _______________________________________________
> Opensim-dev mailing list
> Opensim-dev at lists.berlios.de
> https://lists.berlios.de/mailman/listinfo/opensim-dev
>


-- 
Justin Clark-Casey (justincc)
http://justincc.org/blog
http://twitter.com/justincc