[Opensim-dev] Attachments Module question

[Justin Clark-Casey]

Great stuff.  Passing in just the ControllingClient often means we then have to do some busy work retrieving the SP from 
the scene index again!

On 04/10/11 00:53, Lake, Dan wrote:
> Thanks, Justin. The public interface to AttachmentsModule needed some cleanup too. In every place where interface functions are called, the caller has a ScenePresence but calls the function with sp.ControllingClient. In every case, the AttachmentsModule function implementation would do: m_scence.GetScenePresence(client.agentID) to get the SP back again. I'm changing the public interface to use SP and only the client handlers will still have a need for IClientAPI. In that case, they will look up the SP in scene and call the public interface function. That way, all entry points have the same behavior. So far I have not changed any semantics, just interfaces and removed a lot of duplicated code.
>
> ~Dan
>
>
>
> -----Original Message-----
> From: opensim-dev-bounces at lists.berlios.de [mailto:opensim-dev-bounces at lists.berlios.de] On Behalf Of Justin Clark-Casey
> Sent: Monday, October 03, 2011 3:07 PM
> To: opensim-dev at lists.berlios.de
> Subject: Re: [Opensim-dev] Attachments Module question
>
> This is a probably a bug, though I never got round to changing it since I didn't have time to check that the trigger
> didn't cause anything funky to happen if it was moved lower down.
>
> On 03/10/11 22:01, Lake, Dan wrote:
>> There are two primary versions of AttachObject in the attachments module. One of them is only called as the Client.OnObjectAttach handler. The other version is called in one place each by AttachmentsModuleTests, Scene and LSL_Api to attach an SOG to a SP.
>>
>> The client handler version of AttachObject looks up the SP, looks up the SOG, checks CanTakeObject permission, then calls the other version of AttachObject. After that returns, it calls TriggerOnAttach. TriggerOnAttach is only called in the client event handler version of AttachObject but not when AttachObject is called from Scene or LSL_Api. Does anyone know why that is?
>>
>> ~Dan
>>
>> _______________________________________________
>> Opensim-dev mailing list
>> Opensim-dev at lists.berlios.de
>> https://lists.berlios.de/mailman/listinfo/opensim-dev
>>
>
>


-- 
Justin Clark-Casey (justincc)
http://justincc.org/blog
http://twitter.com/justincc