[Opensim-dev] Renaming innerscene

Thu Nov 6 15:17:25 UTC 2008

I actually have been thinking about border crossings a bit - the current border crossing code forces us to a square region of 256x256 in dimension - I'd actually like to remove that constraint at some point in the future.

I wouldn't mind seeing that being triggered by a module TBH.

Adam

From: opensim-dev-bounces at lists.berlios.de [mailto:opensim-dev-bounces at lists.berlios.de] On Behalf Of Michael Wright
Sent: Thursday, 6 November 2008 7:00 AM
To: opensim-dev at lists.berlios.de
Subject: Re: [Opensim-dev] Renaming innerscene

I totally agree that innerscene shouldn't call out to the Scene. that was one of the things I was looking at when I wrote the original email about how much confusion there is about what InnerScene is meant to be.

Scene/Region should handle all uppper level functions and just call InnerScene to add a new prim to the Scene, or delete a prim. About the only thing that InnerScene needs to signal to a high level is border crossings. So that the Scene/Region level code can communicate with the neghbouring Region.

Melanie <melanie at t-data.com> wrote:
Hi,

What I said.

Look at the flow I illustrated. It should really be:

Caller calls Region:A
Region:A calls Scene:B
Region:A does region things with the return from Scene:B
Region:A returns

No need to dip into Scene (current innerscene) twice. No need for ti
to call out to Region (current Scene).

I would even go as far as saying that, if a method in InnerScene
needs to call a method in Scene, then it doesn't belong into
InnerScene in the first place.

Melanie

Michael Wright wrote:
> Well I think the plan/design was always meant to be based on functional units. Region/current Scene was never meant to be a metadata wrapper around InnerScene. It was meant to contain high level functions, at the region level. Like rezzing a object/ derezzing a object. Linking objects, attaching objects to a Avatar. I wouldn't class those as base scene level functions. And they can be seperated however we want.
>
> I just firmly believe we should have a base layer that has the functionality that is focused on the 3D and sending/receiving clients related to the movement of objects in the scene.
>
> Justin Clark-Casey wrote: Heh, InnerScene has always confused me too - interesting to find out that nobody remembers what it was for (as Alan
> alluded to, this shows the value of writing embedded class level code documentation ;)
>
> I agree with Melanie - I feel that ultimately a split into functional units would be better than having two classes, one
> containing all region related information and one providing scene services. Especially if the outer class just wraps
> the inner classes' methods (but I suspect that wouldn't be the plan).
>
> I assume that the conceptual difference between scene and a region is that the first provides the core simulation
> services while the latter consists of metadata (e.g. which region the scene represents). If there was a separate region
> class, I'm not convinced that there would be very much in it, beyond what is already in RegionInfo.
>
>
> Melanie wrote:
>> As one who has spent a lot of time in InnerScene with the local
>> dragons, I see that in lots of cases, even having it InnerScene at
>> all complicates things horrendously.
>> There are actions that change between Scene and InnerScene 4 times
>> to get the job done. That could be done much more efficiently if
>> those methods were combined and then split up into functional units,
>> rather than "3d" scoped.
>>
>> One flow I found was like this:
>>
>> Caller calls Scene:A
>> Scene:A calls InnerScene:A
>> Scene:A calls Scene:B
>> Scene:A calls InnerScene:C
>> InnerScene:C calls Scene:C
>> Scene:A returns.
>>
>> This is overcomplex and baffling to new coders. I am not surprised
>> that many people choose not to touch it.
>>
>> Needless to say, I removed the above flow and made it into a single
>> call into InnerScene. It was part of attachment rezzing. When i did
>> that, I streamlined that flow.
>>
>> I believe InnerScene and Scene should not be separate, or not be
>> separated along the line they are separated now.
>>
>> On the name, I don't really care.
>>
>> +-0 there.
>>
>> Melanie
>>
>>
>> Frisby, Adam wrote:
>>> +1'ing,
>>>
>>> I had no idea what InnerScene was for myself.
>>>
>>> Adam
>>>
>>> From: opensim-dev-bounces at lists.berlios.de [mailto:opensim-dev-bounces at lists.berlios.de] On Behalf Of Michael Wright
>>> Sent: Thursday, 6 November 2008 5:22 AM
>>> To: opensim-dev at lists.berlios.de
>>> Subject: [Opensim-dev] Renaming innerscene
>>>
>>> A long time ago, we started the process of separating the 3d scene handling code into its own class, rather than having it mixed in with more region level code, like rezzing/inventory handling.
>>>
>>> It was always planned to renamed the InnerScene and Scene classes, once this separation of the 3d scene graph code was completed. The original plan being that Scene became Region (or something like that) and InnerScene changed to Scene.
>>>
>>> It might be a bit to much work to rename the Scene class at this stage. But what are everyone thoughts on renaming InnerScene to something like SceneGraph.
>>>
>>> I think the InnerScene class is one of the more confusing areas as a lot new coders aren't really aware what design role it is meant to play.
>>>
>>>
>>>
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>> _______________________________________________
>>> Opensim-dev mailing list
>>> Opensim-dev at lists.berlios.de
>>> https://lists.berlios.de/mailman/listinfo/opensim-dev
>> _______________________________________________
>> Opensim-dev mailing list
>> Opensim-dev at lists.berlios.de
>> https://lists.berlios.de/mailman/listinfo/opensim-dev
>>
>
>
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Opensim-dev mailing list
> Opensim-dev at lists.berlios.de
> https://lists.berlios.de/mailman/listinfo/opensim-dev
_______________________________________________
Opensim-dev mailing list
Opensim-dev at lists.berlios.de
https://lists.berlios.de/mailman/listinfo/opensim-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://opensimulator.org/pipermail/opensim-dev/attachments/20081106/7430c4b5/attachment-0001.html>