[Opensim-dev] OpenSim codebase statistics.

[Ryan McDougall]

As a new contributor, I think its fantastic to remove unused code.
However it could require a bit of effort to ensure no regressions.

Cheers,

On Fri, 2008-06-27 at 08:49 +0200, Stefan Andersson wrote:
> Suggestion: Can we get our CI build server to 'treat warnings as
> errors'? Then anyone who introduces warnings will get a flip on the
> nose immediately.
> 
> Referring back to the Code Standards we once had : do NOT introduce
> 'stub' or 'future use' fields or functions. Code for what you need
> _now_. Tomorrow may never come. And, judging from our code, in too
> many cases it never did.
>  
> I have a refactoring tool that greys out unused code in Visual Studio,
> so I see it very clearly.
>  
> At some point, I used to just remove it without further ado, but
> nowadays.. what do you all say?
> 
> Best regards,
> Stefan Andersson
> Tribal Media AB
>  
> Join the 3d web revolution : http://tribalnet.se/
>  
> 
> 
> 
> 
> ______________________________________________________________________
> 
> > Date: Fri, 27 Jun 2008 12:32:46 +1200
> > From: mariusz at nowostawski.org
> > To: opensim-dev at lists.berlios.de
> > Subject: Re: [Opensim-dev] OpenSim codebase statistics.
> > 
> > Mike Mazur wrote:
> > 
> > [...]
> > 
> > > There are actually more unit tests (though not many more). Try
> pointing
> > > nunit at bin/OpenSim.Region.ScriptEngine.Common.Tests.dll as well.
> > 
> > Great - thanks. 20 extra existing tests added to the stats. I hope
> more 
> > will come.
> > 
> > >> (note: building is done on the 64-bit Opteron Linux server, and
> all
> > >> the build time is in seconds and the warnings are on Linux with
> mono
> > >> 1.9.1, so they may vary slightly between particular compiler
> used).
> > > 
> > > From what I understand there are some 32-bit binaries that are
> provided
> > > in the SVN checkout. I'm not sure to what extent they're
> referenced at
> > > build time, but since you're building on a 64-bit platform,
> perhaps they
> > > contribute some of the warnings?
> > > 
> > > Somebody more familiar with this can probably clarify further.
> > 
> > As far as I can see none of the warnings is related to the 32-bit
> vs. 
> > 64-bit dependencies - all the warnings are compiler warnings that
> are 
> > cause by the source code not following the ECMA rules, such as:
> > The variable is declared/assigned but its value is never used
> > The private field is declared/assigned but its value is never used
> > The private method is declared but never used
> > The method hides inherited member
> > something obsolete is used,
> > and so on.
> > 
> > What I meant is that various compilers may or may not be religous
> about 
> > all of these warnings, and also it may depend on the particular
> compiler 
> > flags being used. We use the standard build process as it is setup
> on 
> > the SVN trunk itself.
> > 
> > 
> > -- 
> > cheers
> > Mariusz
> 
> _______________________________________________
> Opensim-dev mailing list
> Opensim-dev at lists.berlios.de
> https://lists.berlios.de/mailman/listinfo/opensim-dev