[Opensim-dev] On Mantis #1370 (avatar persistence)

[Sean Dague]

On Wed, Jun 11, 2008 at 06:46:15PM +0900, Johan Berntsson wrote:
> Melaine wrote:
>  > Well, from what I recall of the discussion, this is because if we
>  > store or use asset IDs, and someone changes the item itself, we
>  > would miss that. Of we were to store 13 wearable assets and the
>  > complete set of visual params, and then someone would go and edit
>  > something they're wearing, we'd not apply the edit to the
>  > appearance. So, the inventory is checked at login time to pick up
>  > changes. That was the general idea.
> 
>  > Of course, if we changed things so that wearables were updated right
>  > after leaving the appearance editor, then we could trust that data
>  > on startup. Also, getting the visual params earlier would stop
>  > everyone appearing as anti ruth during login.
> 
> I agree with this. We should be able to trust the asset IDs in the 
> avatarapperance table. Using the inventory server to synchronize it 
> afterwards in each login process is just a bad fix. Much better to fix 
> the code so that they are updated together with the inventory.
> 
> I've removed the Inventory server dependency from AvatarApperance in 
> r5074. It can easily be undone if it creates lots of problems, but it 
> would be better to get a proper fix. Test and let us know what isn't 
> working.

It looks like this nailed it!  Nicely done Johan.

/me owes johan a beer if we ever end up in the same meat space

   -Sean

-- 
__________________________________________________________________

Sean Dague                                       Mid-Hudson Valley
sean at dague dot net                            Linux Users Group
http://dague.net                                 http://mhvlug.org

There is no silver bullet.  Plus, werewolves make better neighbors
than zombies, and they tend to keep the vampire population down.
__________________________________________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://opensimulator.org/pipermail/opensim-dev/attachments/20080611/a117cd58/attachment-0001.pgp>