[Opensim-dev] RFC: Refactoring Scene.cs so that modules directly invoke services from CommsManager

Justin Clark-Casey jjustincc at googlemail.com
Thu Dec 18 16:52:10 UTC 2008


In Scene.cs there are quite a few wrapper methods that appears to exist primarily to relay calls from modules to other 
services.  For instance, Scene.AddXmlRPCHandler() just recalls AddXmlRPCHandler() on the BaseHttpServer.  Some modules 
make use of this method while others use Scene.CommsManager.HttpServer.AddXmlRPCHandler()

I would like to refactor code such that services available through CommsManager are called directly rather than through 
Scene wrappers.  Although this goes against the Law of Demeter (http://en.wikipedia.org/wiki/Law_of_Demeter) I think 
that the advantage in reducing the large number of disparate methods on the Scene is worth it.  The alternative is that 
the number of Scene wrapper methods continues to grow indefinitely as new service methods are introduced.

Comments?

-- 
justincc
Justin Clark-Casey
http://justincc.wordpress.com



More information about the Opensim-dev mailing list