0008848: Typo in AssetData request uri string in AssetServiceConnector

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0008848

opensim

[GRID] Asset Service

public

2021-01-06 05:28

2021-02-06 19:13

Reporter

Chris Weymann

Assigned To

Chris Weymann

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

Operating System

Operating System Version

Product Version

Target Version

Fixed in Version

0.9.2.0 dev

Summary

0008848: Typo in AssetData request uri string in AssetServiceConnector

Description

There is a spelling error in AssetServiceConnector which causes problems in interaction with AssetServerGetHandler.

AssetServiceConnector creates the following URL with "/Data" at the end for retrieving an asset:

http://inc.li:8002/assets/95d2c3fe-03f3-4130-807e-edb0a75708a9/Data [^]

But AssetServerGetHandler expects a URL with a lowercase "/data" at the end.

http://inc.li:8002/assets/95d2c3fe-03f3-4130-807e-edb0a75708a9/data [^]

If AssetServerGetHandler gets a request with an uppercase "/Data" it returns a "Bad Request" error.

Steps To Reproduce

To reproduce this you only need to retrieve an asset with a web client of your choice. In this case I use curl and retrieve the file size.

A call with the incorrect URL:
curl -o asset.jpg2000 http://inc.li:8002/assets/95d2c3fe-03f3-4130-807e-edb0a75708a9/Data [^] && du -h asset.jpg2000 && rm asset.jpg2000

Returns the following file size:
> 0 asset.jpg2000

A call with the correct URL:
curl -o asset.jpg2000 http://inc.li:8002/assets/95d2c3fe-03f3-4130-807e-edb0a75708a9/data [^] && du -h asset.jpg2000 && rm asset.jpg2000

Returns the following file size:
> 48K asset.jpg2000

Additional Information

Normally this error is not noticeable because the regions retrieve their assets together with the metadata. But I have a module in use that needs exactly this function. And basically the correct URL should be used even if this will never happen in practice.

Tags

No tags attached.

Git Revision or version number

Run Mode

Grid (1 Region per Sim) , Grid (Multiple Regions per Sim)

Physics Engine

ubODE

Script Engine

XEngine

Environment

Unknown

Mono Version

None

Viewer

Attached Files

0001-Fix-a-typo-in-AssetServiceConnector-what-makes-troub.patch [^] (1,096 bytes) 2021-01-06 05:28 [Show Content] [Hide Content]

From b4fdb8c89d36ac807dcc83d1d5fd673fdc8b379f Mon Sep 17 00:00:00 2001
From: Chris <christopher@clatza.dev>
Date: Wed, 6 Jan 2021 13:31:26 +0100
Subject: [PATCH] Fix a typo in AssetServiceConnector what makes trouble with
 the HTTP request path parser in AssetServerGetHandler.

---
 OpenSim/Services/Connectors/Asset/AssetServicesConnector.cs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/OpenSim/Services/Connectors/Asset/AssetServicesConnector.cs b/OpenSim/Services/Connectors/Asset/AssetServicesConnector.cs
index 1fad48eea5..c996053613 100644
--- a/OpenSim/Services/Connectors/Asset/AssetServicesConnector.cs
+++ b/OpenSim/Services/Connectors/Asset/AssetServicesConnector.cs
@@ -197,7 +197,7 @@ namespace OpenSim.Services.Connectors
 
             using (RestClient rc = new RestClient(m_ServerURI))
             {
-                rc.AddResourcePath("assets/" + id + "/Data");
+                rc.AddResourcePath("assets/" + id + "/data");
                 rc.RequestMethod = "GET";
 
                 using (MemoryStream s = rc.Request(m_Auth))
-- 
2.29.2.windows.3

Relationships

Notes
(0037466) Chris Weymann (reporter) 2021-01-06 05:29	Add a path to fix this.

(0037467) UbitUmarov (administrator) 2021-01-06 06:48	oops.. master fixed, thanks

(0037542) Chris Weymann (reporter) 2021-02-06 19:13	thanks :3

Issue History
Date Modified	Username	Field	Change
2021-01-06 05:28	Chris Weymann	New Issue
2021-01-06 05:28	Chris Weymann	File Added: 0001-Fix-a-typo-in-AssetServiceConnector-what-makes-troub.patch
2021-01-06 05:29	Chris Weymann	Note Added: 0037466
2021-01-06 05:29	Chris Weymann	Status	new => patch included
2021-01-06 06:48	UbitUmarov	Note Added: 0037467
2021-02-06 19:13	Chris Weymann	Note Added: 0037542
2021-02-06 19:13	Chris Weymann	Status	patch included => resolved
2021-02-06 19:13	Chris Weymann	Fixed in Version	=> 0.9.2.0 dev
2021-02-06 19:13	Chris Weymann	Resolution	open => fixed
2021-02-06 19:13	Chris Weymann	Assigned To	=> Chris Weymann