Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0008667opensim[MISC] Compiling / Buildingpublic2020-03-01 14:392020-03-02 08:47
Reportertampa 
Assigned Totampa 
PrioritynormalSeveritytweakReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOperating SystemOperating System Version
Product Version0.9.1.0 
Target VersionFixed in Versionmaster (dev code) 
Summary0008667: Nunit tests fail
DescriptionUsing the current version of nunit-console the OpenSim.Tests.dll fails at the ConfigLoader Test, the code that seems to fail:

            ini = new IniConfigSource();
            ini.AddConfig("Absolute1").Set("name1", "value1");
            CreateIni("absolute/one/config/setting.ini", ini);

            ini = new IniConfigSource();
            ini.AddConfig("Absolute2").Set("name2", 2.3);
            CreateIni("absolute/two/config/setting1.ini", ini);

            ini = new IniConfigSource();
            ini.AddConfig("Absolute2").Set("name3", "value3");
            CreateIni("absolute/two/config/setting2.ini", ini);

            ini = new IniConfigSource();
            ini.AddConfig("Relative1").Set("name4", "value4");
            CreateIni("relative/one/config/setting.ini", ini);

            ini = new IniConfigSource();
            ini.AddConfig("Relative2").Set("name5", true);
            CreateIni("relative/two/config/setting1.ini", ini);

            ini = new IniConfigSource();
            ini.AddConfig("Relative2").Set("name6", 6);
            CreateIni("relative/two/config/setting2.ini", ini);


All other tests run fine when that particular one isn't run. I know the official buildserver still uses the ancient nunit-console2 which is no longer part of mono and only found in versions prior 2.10

It would be nice if the project, having upgraded the minimum version of mono recently would also go along and adopt more current methods of testing, especially if the reproducibility of these tests is yet another indicator of whether a change is working or potentially causing issues.
Steps To ReproduceRun nunit-console ./bin/OpenSim.Tests.dll -xml=test-results/OpenSim.Tests.dll-Results.xml on freshly built master
Additional Information<failure>
                      <message><![CDATA[ Configuration with includes does not contain all settings.
  String lengths are both 249. Strings differ at index 157.
  Expected: "...e1 = value1\r\n[Absolute2]\r\nname2 = 2.3\r\nname3 = value3\r\n[Re..."
  But was: "...e1 = value1\r\n[Absolute2]\r\nname3 = value3\r\nname2 = 2.3\r\n[Re..."
  ------------------------------------------------^
]]></message>
                      <stack-trace><![CDATA[at OpenSim.Tests.ConfigurationLoaderTests.IncludeTests () [0x00220] in <306f28fe4c874523899e5f7fd0fee827>:0
at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in <a1ae6166591d4020b810288d19af38d4>:0
]]></stack-trace>
</failure>
TagsNo tags attached.
Git Revision or version number
Run ModeStandalone (1 Region) , Standalone (Multiple Regions) , Grid (1 Region per Sim) , Grid (Multiple Regions per Sim)
Physics EngineBulletSim
Script EngineXEngine
EnvironmentMono / Linux64
Mono Version6.x
Viewer
Attached Files

- Relationships

-  Notes
(0036233)
UbitUmarov (administrator)
2020-03-01 14:57

like many tests, that one is just bad
if you look the diference is just the order of name2 and name3
(0036234)
UbitUmarov (administrator)
2020-03-01 15:24
edited on: 2020-03-01 15:27

the cause for that is on code before the one pasted here:

config.Set("Include-absolute", "absolute/*/config/*.ini");

this will depend on the order mono or .net or the operation system will return folders and files from wildcards, and no order is garanted

that test just happens to pass on windows .net4.8, unreliable elsewhere
this is also a warning about the use of wildcards on configuration includes
specially where overrides are to be expected

just do not use wildcards when order matters

(0036238)
tampa (reporter)
2020-03-02 08:47

The change on master seems to have resolved the issue, 312 tests passing as should be, thanks!

- Issue History
Date Modified Username Field Change
2020-03-01 14:39 tampa New Issue
2020-03-01 14:57 UbitUmarov Note Added: 0036233
2020-03-01 15:24 UbitUmarov Note Added: 0036234
2020-03-01 15:27 UbitUmarov Note Edited: 0036234 View Revisions
2020-03-01 16:02 tampa Description Updated View Revisions
2020-03-02 08:47 tampa Note Added: 0036238
2020-03-02 08:47 tampa Status new => resolved
2020-03-02 08:47 tampa Fixed in Version => master (dev code)
2020-03-02 08:47 tampa Resolution open => fixed
2020-03-02 08:47 tampa Assigned To => tampa


Copyright © 2000 - 2012 MantisBT Group
Powered by Mantis Bugtracker