0008411: Coalesced items in inventory are no longer shown with the coalesced item icon and other inventory weirdness

(0033522)
BillBlight (developer)
2018-11-22 10:51
edited on: 2018-11-22 11:28

What version of firestorm are you using?? What type of asset server , Xassets or fsassets ..

Tried to replicate it, attached image.

EDIT: I am testing with very latest master.

(0033523)
BillBlight (developer)
2018-11-22 17:10
edited on: 2018-11-22 17:10

@mewtwo0641 Ubit did find something wrong that just seemed to not affect me, so there is a new master with hopefully a fix ..

(0033524)
UbitUmarov (administrator)
2018-11-22 17:15

yes I made a change on master

(0033525)
mewtwo0641 (reporter)
2018-11-22 17:42

@BillBlight - Sorry about that, I was a bit tired when I posted the mantis. But I was testing with the latest Firestorm (v5.1.7.55786). The asset server is standard MySQL storage (not FSAssets). Also I probably should have clarified that you won't see the issue if you make a new coalesced item; It only affects existing items in inventory. I did notice that if I duplicate (Copy and paste elsewhere in inventory) the item that is supposed to have the coalesced icon does have the proper icon on the newly copied item, but the new item then has the wrong icon upon next relog (Possibly after clearing viewer cache)

@Ubit - Thanks for looking into this Ubit, I am having a bit of trouble compiling master in order to test though.

Compile Error:

"D:\ostest\opensim.sln" (default target) (1) ->
"D:\ostest\OpenSim\Region\ScriptEngine\YEngine\OpenSim.Region.ScriptEngine.YEngine.csproj" (default target) (64) ->
(CoreCompile target) ->
XMRInstCtor.cs(894,37): error CS0136: A local variable named 'eventCode' cannot be declared in this scope because it would give a different me
aning to 'eventCode', which is already used in a 'parent or current' scope to denote something else [D:\ostest\OpenSim\Region\ScriptEngine\YEngine\OpenSim.Region.ScriptEngine.YEngine.csproj]

(0033526)
BillBlight (developer)
2018-11-22 17:51

@mewtwo0641 hmm never seen that exact compile error, have you tried a completely clean download, into a fresh empty directory?

(0033527)
UbitUmarov (administrator)
2018-11-22 17:55

that should be at most a warning (that I don't see on VS or mono)
but changed on master, also for clarity

(0033528)
mewtwo0641 (reporter)
2018-11-22 17:57

@BillBlight - I just tried on a fresh newly cloned opensim download with the same error

(0033529)
mewtwo0641 (reporter)
2018-11-22 18:04
edited on: 2018-11-22 18:10

@Ubit - The latest change on master does compile. I am a little confused by the change though

ScriptEventCode evtCode = (ScriptEventCode)Enum.Parse(typeof(ScriptEventCode),
evt.EventName);

m_EventCounts[(int)eventCode]++;

The variable name was changed in its declaration but m_EventCounts[(int)eventCode]++; wasn't changed to reflect that name change. So ScriptEventCode evtCode = ... Would be essentially doing nothing?

(0033530)
UbitUmarov (administrator)
2018-11-22 18:44

Ooops...
fixed, thx

(0033531)
UbitUmarov (administrator)
2018-11-22 18:47

changed also some code on take, take copy.. of more than 250 objects
note this may fail a lot
you need to wait for viewer to finish the select, and this can take a lot of time!!

MySQL config option max_allowed_packet needs to be large enough (also for other things)

(0033532)
mewtwo0641 (reporter)
2018-11-22 19:21

@Ubit - No problem :)

I tested again and it appears the coalesced items in inventory are showing up with the correct icon now. Tested with Firestorm, Alchemy, and Singularity. All are latest release except Singularity which is a slightly-older-than-latest-build Alpha.

Although there are still some coalesced objects that refuse to rez for me (And rezzes just fine on older code i.e. 0.8.x series and most recent public release). This may be a seperate issue though; I will have to test some more and see if I can pinpoint a spot in time when that first started happening.

I have max_allowed_packet set to 1024M, which is probably waaaay overkill, but I am pretty sure the objects that are failing to rez don't come anywhere near approaching that.

Thank you!

Issue History
Date Modified	Username	Field	Change
2018-11-22 05:03	mewtwo0641	New Issue
2018-11-22 05:03	mewtwo0641	Steps to Reproduce Updated	View Revisions
2018-11-22 10:50	BillBlight	File Added: mantis8411.png
2018-11-22 10:51	BillBlight	Note Added: 0033522
2018-11-22 10:54	BillBlight	File Added: manstis 8411_singu.png
2018-11-22 11:04	BillBlight	File Added: mantis8411_win_net_xassets.png
2018-11-22 11:28	BillBlight	Note Edited: 0033522	View Revisions
2018-11-22 17:10	BillBlight	Note Added: 0033523
2018-11-22 17:10	BillBlight	Note Edited: 0033523	View Revisions
2018-11-22 17:15	UbitUmarov	Note Added: 0033524
2018-11-22 17:42	mewtwo0641	Note Added: 0033525
2018-11-22 17:48	mewtwo0641	Steps to Reproduce Updated	View Revisions
2018-11-22 17:51	BillBlight	Note Added: 0033526
2018-11-22 17:55	UbitUmarov	Note Added: 0033527
2018-11-22 17:57	mewtwo0641	Note Added: 0033528
2018-11-22 18:04	mewtwo0641	Note Added: 0033529
2018-11-22 18:10	mewtwo0641	Note Edited: 0033529	View Revisions
2018-11-22 18:44	UbitUmarov	Note Added: 0033530
2018-11-22 18:47	UbitUmarov	Note Added: 0033531
2018-11-22 19:21	mewtwo0641	Note Added: 0033532

Notes
(0033522) BillBlight (developer) 2018-11-22 10:51 edited on: 2018-11-22 11:28	What version of firestorm are you using?? What type of asset server , Xassets or fsassets .. Tried to replicate it, attached image. EDIT: I am testing with very latest master.

(0033523) BillBlight (developer) 2018-11-22 17:10 edited on: 2018-11-22 17:10	@mewtwo0641 Ubit did find something wrong that just seemed to not affect me, so there is a new master with hopefully a fix ..

(0033524) UbitUmarov (administrator) 2018-11-22 17:15	yes I made a change on master

(0033525) mewtwo0641 (reporter) 2018-11-22 17:42	@BillBlight - Sorry about that, I was a bit tired when I posted the mantis. But I was testing with the latest Firestorm (v5.1.7.55786). The asset server is standard MySQL storage (not FSAssets). Also I probably should have clarified that you won't see the issue if you make a new coalesced item; It only affects existing items in inventory. I did notice that if I duplicate (Copy and paste elsewhere in inventory) the item that is supposed to have the coalesced icon does have the proper icon on the newly copied item, but the new item then has the wrong icon upon next relog (Possibly after clearing viewer cache) @Ubit - Thanks for looking into this Ubit, I am having a bit of trouble compiling master in order to test though. Compile Error: "D:\ostest\opensim.sln" (default target) (1) -> "D:\ostest\OpenSim\Region\ScriptEngine\YEngine\OpenSim.Region.ScriptEngine.YEngine.csproj" (default target) (64) -> (CoreCompile target) -> XMRInstCtor.cs(894,37): error CS0136: A local variable named 'eventCode' cannot be declared in this scope because it would give a different me aning to 'eventCode', which is already used in a 'parent or current' scope to denote something else [D:\ostest\OpenSim\Region\ScriptEngine\YEngine\OpenSim.Region.ScriptEngine.YEngine.csproj]

(0033526) BillBlight (developer) 2018-11-22 17:51	@mewtwo0641 hmm never seen that exact compile error, have you tried a completely clean download, into a fresh empty directory?

(0033527) UbitUmarov (administrator) 2018-11-22 17:55	that should be at most a warning (that I don't see on VS or mono) but changed on master, also for clarity

(0033528) mewtwo0641 (reporter) 2018-11-22 17:57	@BillBlight - I just tried on a fresh newly cloned opensim download with the same error

(0033529) mewtwo0641 (reporter) 2018-11-22 18:04 edited on: 2018-11-22 18:10	@Ubit - The latest change on master does compile. I am a little confused by the change though ScriptEventCode evtCode = (ScriptEventCode)Enum.Parse(typeof(ScriptEventCode), evt.EventName); m_EventCounts[(int)eventCode]++; The variable name was changed in its declaration but m_EventCounts[(int)eventCode]++; wasn't changed to reflect that name change. So ScriptEventCode evtCode = ... Would be essentially doing nothing?

(0033530) UbitUmarov (administrator) 2018-11-22 18:44	Ooops... fixed, thx

(0033531) UbitUmarov (administrator) 2018-11-22 18:47	changed also some code on take, take copy.. of more than 250 objects note this may fail a lot you need to wait for viewer to finish the select, and this can take a lot of time!! MySQL config option max_allowed_packet needs to be large enough (also for other things)

(0033532) mewtwo0641 (reporter) 2018-11-22 19:21	@Ubit - No problem :) I tested again and it appears the coalesced items in inventory are showing up with the correct icon now. Tested with Firestorm, Alchemy, and Singularity. All are latest release except Singularity which is a slightly-older-than-latest-build Alpha. Although there are still some coalesced objects that refuse to rez for me (And rezzes just fine on older code i.e. 0.8.x series and most recent public release). This may be a seperate issue though; I will have to test some more and see if I can pinpoint a spot in time when that first started happening. I have max_allowed_packet set to 1024M, which is probably waaaay overkill, but I am pretty sure the objects that are failing to rez don't come anywhere near approaching that. Thank you!

Relationships