Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0008246opensim[REGION] OpenSim Corepublic2017-10-05 08:212017-10-06 00:30
Reportermewtwo0641 
Assigned Tomewtwo0641 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0008246: Proposal - "delete object name" command should not be able to delete/remove attachments
DescriptionI can't see any good reason why the "delete object name" command should be able to remove/delete people's attachments when used so I have provided a patch to fix this.

I'm unsure if this is the best way to do it but in my testings of the patch it seems to work without issue.
TagsNo tags attached.
Git Revision or version number
Run Mode Grid (Multiple Regions per Sim)
Physics EngineubODE
Environment.NET / Windows64
Mono VersionNone
Viewer
Attached Filespatch file icon 0001-Strip-attachment-SOGs-from-deletes-when-using-delete.patch [^] (1,648 bytes) 2017-10-05 08:21 [Show Content]

- Relationships

-  Notes
(0032311)
watcher64 (reporter)
2017-10-05 14:32

Just going to throw this out there, I think it is a bad idea to disabled this, for a couple of reasons.

1.) This is a console command so only grid owners/runners should have access to it anyway.

2.) If it is a scripted attachment that is causing the issues, and you NEED to get rid of it, as a means of last resort, then this would eliminate this ability.
(0032312)
mewtwo0641 (reporter)
2017-10-05 17:52

I believe it's an issue because it doesn't just disable or detach the attachment; It actually trashes it and removes the object from the owner's inventory... Which would be really bad for console admins simply looking to clean up a region and accidentally deleting attachments unintentionally (Such as via the --regex option).

Looking through the code for the other accompanying "delete object ..." commands they're all doing checks to make sure that they're not gathering attachments SOGs for deletion. In fact through testing each type of "delete object ..." command I've found that only "delete object name" is capable of removing attachments in that manner so it's led me to believe that it was simply an oversight when the command was implemented.

There are other ways to deal with problematic attachment scripts that don't result in destroying the user's objects such as the scripts stop command (Which if I remember correctly can be used to stop a single object's scripts), kicking the user from the region/sim/grid, banning them, or just simply asking them to remove their attachment.
(0032313)
UbitUmarov (administrator)
2017-10-05 18:48

Ok, changed master code to not allow it.
But made 'delete object id' do it with confirmation request.
Sorry made other code
Thanks
(0032314)
mewtwo0641 (reporter)
2017-10-06 00:30

Recent commit seems to work fine. Thank you!

- Issue History
Date Modified Username Field Change
2017-10-05 08:21 mewtwo0641 New Issue
2017-10-05 08:21 mewtwo0641 File Added: 0001-Strip-attachment-SOGs-from-deletes-when-using-delete.patch
2017-10-05 08:22 mewtwo0641 Status new => patch included
2017-10-05 14:32 watcher64 Note Added: 0032311
2017-10-05 17:52 mewtwo0641 Note Added: 0032312
2017-10-05 18:48 UbitUmarov Note Added: 0032313
2017-10-06 00:30 mewtwo0641 Note Added: 0032314
2017-10-06 00:30 mewtwo0641 Status patch included => resolved
2017-10-06 00:30 mewtwo0641 Resolution open => fixed
2017-10-06 00:30 mewtwo0641 Assigned To => mewtwo0641


Copyright © 2000 - 2012 MantisBT Group
Powered by Mantis Bugtracker