Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0007897opensim[REGION] OpenSim Corepublic2016-05-02 08:342017-06-27 03:01
Reportercuteulala 
Assigned To 
PrioritylowSeveritytweakReproducibilityalways
Statuspatch includedResolutionopen 
PlatformOSOS Version
Product Versionmaster (dev code) 
Target VersionFixed in Version 
Summary0007897: NPC Are Not Ignored By Access List
DescriptionNPC are ejected from a region thats locked to a access list in about land and estate settings. This makes it hard to use NPC on a locked region and should be changed
Steps To ReproducePrevent public access on about land and estate settings and then rez a npc next to you. They will get ejected
TagsNo tags attached.
Git Revision or version number
Run ModeStandalone (1 Region)
Physics EngineOther
Script Engine
Environment.NET / Windows64
Mono VersionNone
ViewerSingularity
Attached Filespatch file icon 0001-Permission-for-access-of-NPC-created-with-flag-OS_NP.patch [^] (1,224 bytes) 2016-06-28 08:54 [Show Content]

- Relationships
duplicate of 0007795closedMata Hari When rezzed, NPCs drift to edge of sim 

-  Notes
(0030260)
melanie (administrator)
2016-05-02 08:41

It's actually a bit more complicated. NPC should get ejected if the person owning the prim that rezzes them doesn't have the right to be on that land.

I agree this needs work.
(0030261)
Mandarinka Tasty (reporter)
2016-05-02 10:49
edited on: 2016-05-02 10:52

Cuteulala means: when she terminates access - closes access to her land ( to her region )in about land setting and / or in estate window, then

her npc bots do not have access, either, and that makes problem for her.

Because simulator treats her Npc bots like other avatars and ejects them.

She wants to experiment with her npc bots and in same time she does not want others to come to her region. I understand her report in such way.

(0030265)
Mata Hari (reporter)
2016-05-03 07:57

This is not strictly a duplicate of my report 0007795. That was about group permission and was resolved by adding a flag to the osNpcCreate() function. This bug applies to parcels that can only be accessed via access list.

As Melanie says, at the time a NPC is created it should inherit the same parcel access permissions as the owner of the script that creates it.
(0030267)
Mandarinka Tasty (reporter)
2016-05-03 08:37

Yes, exactly:

NPC should obtain analogous permission as its creator, in aspect of access permissions, as Mata Hari mentions.

And in same time, NPC should be ejected, when its owner has not access permissions, as Melanie mentions.

Those, similar, though different things need to work, both. Absolutely agreed.

Dan suggests, that http://opensimulator.org/mantis/view.php?id=7795 [^]

can be considered as kind of workaround for Cuteulala to manage their NPC bots.

It's not precise duplication, but it can help , maybe, to solve her problem.

It needs some test: create NPC with flag, NPC_OWNED and NPC_OBJECT_GROUP

maybe then, udner such conditions, simulator does not eject NPC bot from

the parcel. I have not verified it.
(0030268)
Mata Hari (reporter)
2016-05-03 09:39

Unfortunately every time you add new flags you then make all existing scripts that use that function become obsolete. I already spent a couple months updating all of my products to be compatible with the changes made to group access in 0.9 so I'll be very unimpressed if I have to go through and do them all again.

I would very much hope that any further fixes/changes use the existing (ie 0.8.2.1) behaviour as their defaults and only require the use of flags to _change_ that to something else.
(0030816)
Mandarinka Tasty (reporter)
2016-06-28 08:55
edited on: 2016-06-28 08:56

I have offered the patch, that allows for access for NPC,that has been created

with flag OS_NPC_OBJECT_GROUP to the parcel, where access is only for

land group members.

Regards

(0030817)
UbitUmarov (administrator)
2016-06-28 09:01

wasn't OS_NPC_OBJECT_GROUP already working on land restricted to group ?
(0030819)
Mandarinka Tasty (reporter)
2016-06-28 09:03

no, it was not.
(0030821)
Mata Hari (reporter)
2016-06-28 10:00

It doesn't compile. You have to use the value (8) instead, then it works.
(0030822)
UbitUmarov (administrator)
2016-06-28 10:05

ok OS_NPC_OBJECT_GROUP got broken with recent changes to parcel access control on completemovement. Testing a fix.
(0030823)
Mandarinka Tasty (reporter)
2016-06-28 10:14

Hello :) what do you mean Mata saying value (8) ?

I have compiled it using visual studio and last version of master. There were no errors.
(0030824)
UbitUmarov (administrator)
2016-06-28 10:24

pushed code fixing OS_NPC_OBJECT_GROUP
problem is that group information now needs to be applied to the npc sooner due to changes in completmovement access control.

the submitted patch would not fix the issue, was doing the same that current code already did in a different away.

parcel access by access list, still doesn't work :(
(0030825)
UbitUmarov (administrator)
2016-06-28 10:30

just to clarify sp.ControllingClient.IsGroupMember(LandData.GroupID);
does the check, since ControllingClient is a special NPC control client
(see ..\NPCAvatar.cs public bool IsGroupMember(UUID groupID) around line 597)
(0030826)
Mata Hari (reporter)
2016-06-28 11:46
edited on: 2016-06-28 12:08

@Mandarinka: when you use it in a script and attempt to run the script on a region running under 0.8.x it will fail to compile at all and be non-functional. The only way you can script to support both 0.8.x and 0.9.x is to use the integer value (=8). EDIT: just to be clear, I'm talking about the _script_ not compiling, not about Opensim failing to compile.

It doesn't matter if you're only doing something for your own purposes, but if you're a creator who wants to be able to share your creations with others, you try to write your script to support your "customers" which means that you can't use OS_NPC_OBJECT_GROUP in your script if you want it to work on a region running the current official version of Opensim.

(0030827)
Mandarinka Tasty (reporter)
2016-06-28 12:28

@ Mata :)

I've understood now what you had meant .

Yes, i have prepared fix only for version 0.9.

Hence, script, in-world, could not be compiled. Right.

I confess, that I've been told, to not deal with fixes for 0.8 and nothing

is going to be prepared to fix 0.8 anymore.

So that's why I build my fixes using 0.9

Anyway, thank you for reminding that )
(0030828)
UbitUmarov (administrator)
2016-06-28 12:39

well I don't understand what you are talking about.
this mantis was for 0.9 and OS_NPC_OBJECT_GROUP is a 0.9 option.
and none of this is related to access list.
(0030829)
UbitUmarov (administrator)
2016-06-28 15:36

push some trial code:
[23:31] <cia-opensim> if a NPC is owned, allow access if ownerID matchs parcel owner or it is in the access list. option OS_NPC_OBJECT_GROUP it still needed if access is by group (this option should also work with not owned NPC) NEEDS TESTING, may prove to be a bad solution
(0032081)
djphil (reporter)
2017-06-26 06:57
edited on: 2017-06-28 09:21

I'm testing OS_NPC_OBJECT_GROUP this morning
It seem work fine ...

I add this new option on the OpenSim Wiki

OS_NPC_OBJECT_GROUP @ http://opensimulator.org/wiki/OsNpcCreate [^]
OS_NPC_OBJECT_GROUP @ http://opensimulator.org/wiki/OSSLNPC#osNpcCreate [^]
OS_NPC_OBJECT_GROUP @ http://opensimulator.org/wiki/OSSL_Constants [^]

(i hope is the right place to put it and correctly commented)

(0032083)
djphil (reporter)
2017-06-26 09:20

I still found little problem
The group carried does not appear on the profile of the Npc
Screenshot @ http://i.imgur.com/y8j1192.jpg [^]
(0032088)
UbitUmarov (administrator)
2017-06-26 20:57

yes npc group was not added to profile still (I think im testing at osg now with a old module)
(0032089)
djphil (reporter)
2017-06-27 03:01

It is a small detail yes but with, the npc will be even prettier :)

- Issue History
Date Modified Username Field Change
2016-05-02 08:34 cuteulala New Issue
2016-05-02 08:41 melanie Note Added: 0030260
2016-05-02 10:49 Mandarinka Tasty Note Added: 0030261
2016-05-02 10:50 Mandarinka Tasty Note Edited: 0030261 View Revisions
2016-05-02 10:51 Mandarinka Tasty Note Edited: 0030261 View Revisions
2016-05-02 10:52 Mandarinka Tasty Note Edited: 0030261 View Revisions
2016-05-02 20:19 danbanner Relationship added duplicate of 0007795
2016-05-03 07:57 Mata Hari Note Added: 0030265
2016-05-03 08:37 Mandarinka Tasty Note Added: 0030267
2016-05-03 09:39 Mata Hari Note Added: 0030268
2016-06-28 08:54 Mandarinka Tasty File Added: 0001-Permission-for-access-of-NPC-created-with-flag-OS_NP.patch
2016-06-28 08:55 Mandarinka Tasty Note Added: 0030816
2016-06-28 08:55 Mandarinka Tasty Status new => patch included
2016-06-28 08:56 Mandarinka Tasty Note Edited: 0030816 View Revisions
2016-06-28 09:01 UbitUmarov Note Added: 0030817
2016-06-28 09:03 Mandarinka Tasty Note Added: 0030819
2016-06-28 10:00 Mata Hari Note Added: 0030821
2016-06-28 10:05 UbitUmarov Note Added: 0030822
2016-06-28 10:14 Mandarinka Tasty Note Added: 0030823
2016-06-28 10:24 UbitUmarov Note Added: 0030824
2016-06-28 10:30 UbitUmarov Note Added: 0030825
2016-06-28 11:46 Mata Hari Note Added: 0030826
2016-06-28 11:47 Mata Hari Note Edited: 0030826 View Revisions
2016-06-28 12:08 Mata Hari Note Edited: 0030826 View Revisions
2016-06-28 12:28 Mandarinka Tasty Note Added: 0030827
2016-06-28 12:39 UbitUmarov Note Added: 0030828
2016-06-28 15:36 UbitUmarov Note Added: 0030829
2017-06-26 06:57 djphil Note Added: 0032081
2017-06-26 09:20 djphil Note Added: 0032083
2017-06-26 20:57 UbitUmarov Note Added: 0032088
2017-06-27 03:01 djphil Note Added: 0032089
2017-06-28 09:21 djphil Note Edited: 0032081 View Revisions


Copyright © 2000 - 2012 MantisBT Group
Powered by Mantis Bugtracker