Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0007747opensim[REGION] OpenSim Corepublic2015-11-22 04:302018-08-27 04:39
Reporteraiaustin 
Assigned To 
PrioritynormalSeveritymajorReproducibilityalways
StatusacknowledgedResolutionopen 
PlatformPCOSWindowsOS Version10
Product Versionmaster (dev code) 
Target Versionmaster (dev code)Fixed in Version 
Summary0007747: LLoginService.cs login response has extra fields causing addon errors, plus question on special Radegast handling
DescriptionAt OpenSim\Services\LLLoginService\LLLoginService.cs there have been additional parameters added to the login response. This change causes addon packages which construct this response to give compilation errors. These will have to be changed by the addon developers, e.g. @Diva's Wifi.

In the definition of LoginResponse, since the avination merge, an extra bool parameter for "LibOMVclient" has been added. It may be worth checking if the LibOMVClient parameter is required, as looking at the code it seems to be there for special handling for the Radegast viewer. However, Radegast has always worked fine up to now without this special handling.

 
TagsNo tags attached.
Git Revision or version numberopensim-0.9.0-85-gf75d113
Run Mode Standalone (Multiple Regions)
Physics EngineBasicPhysics
Environment.NET / Windows64
Mono VersionNone
ViewerN/A
Attached Files

- Relationships

-  Notes
(0029616)
UbitUmarov (administrator)
2015-11-23 15:54

Yes there are extra parameters.
(0029623)
aiaustin (developer)
2015-11-24 01:31
edited on: 2015-11-24 01:40

I now see in other commits that the LibOMVclient parameter in LoginReponse is set and used in OpenSim/Server/Handlers/Login/LLLoginHandlers.cs

The special handling for Radegast (lack of proxy handling?) which I assume is needed is in OpenSim/Services/LLLoginService/LLLoginService.cs

(0031166)
cb-dtf (reporter)
2016-09-30 01:32

How can it be that Radegast gets to have special handling?
If there indeed is a compatibility problem, should this not be handled by Radegast instead?

Who gets to decide what compatibility tweaks can be in the main source or not?
(0031167)
UbitUmarov (administrator)
2016-09-30 07:51

the LibOMVclient detection is only used on a display message for log and console and it is not about Radegast. It is included because it may still be usefully for some grid admins, like it was for avination.

Opensim-devs decide what is include or not in opensim. That, and internal decision process is describe some where on our site. (sorry not going look for it now)
(0032896)
Fly-Man- (developer)
2018-08-27 04:39

The LibOMVClient parameter has nothing to do with Radegast but more with the LibOpenMetaverse client programs.

As Ubit already has explained, that value is always false unless you use a LibOMV client to connect to the grid in which the value will be true.

- Issue History
Date Modified Username Field Change
2015-11-22 04:30 aiaustin New Issue
2015-11-22 12:46 aiaustin Summary LLoginSerive.cs login response has extra bool LibOMVClient for Radegast clients since avination merge causing add on errors => LLoginService.cs login response has extra bool LibOMVClient for Radegast clients since avination merge causing add on errors
2015-11-22 12:50 aiaustin Summary LLoginService.cs login response has extra bool LibOMVClient for Radegast clients since avination merge causing add on errors => LLoginService.cs login response has extra bool LibOMVClient for Radegast clients since avination merge causing addon errors
2015-11-22 12:50 aiaustin Description Updated View Revisions
2015-11-23 02:11 aiaustin Summary LLoginService.cs login response has extra bool LibOMVClient for Radegast clients since avination merge causing addon errors => LLoginService.cs login response has extra fields causing addon errors
2015-11-23 02:11 aiaustin Description Updated View Revisions
2015-11-23 02:12 aiaustin Description Updated View Revisions
2015-11-23 02:25 aiaustin Description Updated View Revisions
2015-11-23 03:55 aiaustin Description Updated View Revisions
2015-11-23 05:06 aiaustin Summary LLoginService.cs login response has extra fields causing addon errors => LLoginService.cs login response has extra fields causing addon errors, plus question on special Radegast handling
2015-11-23 05:06 aiaustin Description Updated View Revisions
2015-11-23 15:54 UbitUmarov Note Added: 0029616
2015-11-24 01:31 aiaustin Note Added: 0029623
2015-11-24 01:39 aiaustin Note Edited: 0029623 View Revisions
2015-11-24 01:40 aiaustin Note Edited: 0029623 View Revisions
2015-11-24 01:40 aiaustin Note Edited: 0029623 View Revisions
2016-09-30 01:32 cb-dtf Note Added: 0031166
2016-09-30 07:51 UbitUmarov Note Added: 0031167
2018-08-27 04:39 Fly-Man- Note Added: 0032896
2018-08-27 04:39 Fly-Man- Status new => acknowledged


Copyright © 2000 - 2012 MantisBT Group
Powered by Mantis Bugtracker