Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0007746opensim[MISC] Compiling / Buildingpublic2015-11-20 13:522015-11-21 09:06
Reporterfrost 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Statuspatch includedResolutionopen 
PlatformOSOS Version
Product Versionmaster (dev code) 
Target VersionFixed in Version 
Summary0007746: fix warnings introduced with avination merge
DescriptionThe avination merge left a fair number of compile-time warnings. Fix.
Steps To Reproduce1. clone fresh repo
2. ./runprebuild.sh
3. nant
Additional InformationAs discussed on the mailing list, creating issue and creating patches.
TagsNo tags attached.
Git Revision or version number019d057563e741833463cadd2beccdfe79d19ebe
Run Mode Grid (Multiple Regions per Sim)
Physics EngineOther
Script Engine
EnvironmentUnknown
Mono VersionNone
Viewer
Attached Filespatch file icon 0001-0007746-remove-unused-private-member-m_ForeignImport.patch [^] (1,446 bytes) 2015-11-20 14:13 [Show Content]
patch file icon 0002-0007746-remove-unused-private-members-from-Capabilit.patch [^] (7,104 bytes) 2015-11-20 14:13 [Show Content]
patch file icon 0003-0007746-remove-unused-private-members-from-various-F.patch [^] (8,696 bytes) 2015-11-20 14:14 [Show Content]
patch file icon 0004-LLClientView-clean-up-code-that-is-commented-out.patch [^] (4,665 bytes) 2015-11-20 14:14 [Show Content]
patch file icon 0005-0007746-remove-unused-private-members.patch [^] (5,558 bytes) 2015-11-20 14:14 [Show Content]
patch file icon 0006-0007746-remove-unused-private-members-from-EntityTra.patch [^] (1,079 bytes) 2015-11-20 14:14 [Show Content]
patch file icon 0007-0007746-clean-up-using-statements-in-ITerrainModule.patch [^] (791 bytes) 2015-11-20 14:14 [Show Content]
patch file icon 0008-0007746-remove-unused-private-members-from-files-und.patch [^] (11,013 bytes) 2015-11-20 14:15 [Show Content]
patch file icon 0009-0007746-remove-unused-private-members-from-BulletSim.patch [^] (7,827 bytes) 2015-11-20 14:15 [Show Content]
patch file icon 0010-0007746-remove-unused-variable-declaration-from-ODET.patch [^] (1,184 bytes) 2015-11-20 14:15 [Show Content]
patch file icon 0011-0007746-remove-unused-variables-from-ScriptEngine-me.patch [^] (2,952 bytes) 2015-11-20 14:15 [Show Content]
patch file icon 0012-0007746-remove-unused-variables-from-Services.patch [^] (2,643 bytes) 2015-11-20 14:15 [Show Content]
patch file icon 0013-0007746-remove-unused-private-members-from-SmartThre.patch [^] (2,865 bytes) 2015-11-20 14:15 [Show Content]

- Relationships

-  Notes
(0029591)
frost (reporter)
2015-11-20 14:17

Attached 13 patches with the first low-hanging fruit. I clustered the patches a bit, hope that is ok. I can resubmit one big patch if required.
(0029592)
UbitUmarov (administrator)
2015-11-20 17:32

Hi, thanks but please stop for now :( You are also removing comments, dead code, etc, and that needs to be checked case by case, even some unused variables are there waiting future use
You removed for example debug messages that we put back every time we need.
I can't apply patches like this automatically. I will use them as reference.
I did remove a few of those warnings, increasing the total reported by 2 ;)

- Issue History
Date Modified Username Field Change
2015-11-20 13:52 frost New Issue
2015-11-20 14:13 frost File Added: 0001-0007746-remove-unused-private-member-m_ForeignImport.patch
2015-11-20 14:13 frost File Added: 0002-0007746-remove-unused-private-members-from-Capabilit.patch
2015-11-20 14:14 frost File Added: 0003-0007746-remove-unused-private-members-from-various-F.patch
2015-11-20 14:14 frost File Added: 0004-LLClientView-clean-up-code-that-is-commented-out.patch
2015-11-20 14:14 frost File Added: 0005-0007746-remove-unused-private-members.patch
2015-11-20 14:14 frost File Added: 0006-0007746-remove-unused-private-members-from-EntityTra.patch
2015-11-20 14:14 frost File Added: 0007-0007746-clean-up-using-statements-in-ITerrainModule.patch
2015-11-20 14:15 frost File Added: 0008-0007746-remove-unused-private-members-from-files-und.patch
2015-11-20 14:15 frost File Added: 0009-0007746-remove-unused-private-members-from-BulletSim.patch
2015-11-20 14:15 frost File Added: 0010-0007746-remove-unused-variable-declaration-from-ODET.patch
2015-11-20 14:15 frost File Added: 0011-0007746-remove-unused-variables-from-ScriptEngine-me.patch
2015-11-20 14:15 frost File Added: 0012-0007746-remove-unused-variables-from-Services.patch
2015-11-20 14:15 frost File Added: 0013-0007746-remove-unused-private-members-from-SmartThre.patch
2015-11-20 14:17 frost Note Added: 0029591
2015-11-20 14:17 frost Status new => patch included
2015-11-20 17:32 UbitUmarov Note Added: 0029592


Copyright © 2000 - 2012 MantisBT Group
Powered by Mantis Bugtracker