| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] |
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0007587 | opensim | [REGION] Script Functions | public | 2015-05-23 05:16 | 2015-05-23 07:20 |
|
| Reporter | Magnuz | |
| Assigned To | nebadon | |
| Priority | normal | Severity | minor | Reproducibility | sometimes |
| Status | closed | Resolution | fixed | |
| Platform | Intel Core i7 | OS | Ubuntu | OS Version | 14.04 |
| Product Version | master (dev code) | |
| Target Version | | Fixed in Version | master (dev code) | |
|
| Summary | 0007587: llCastRay V3 suffers mesh cache race condition |
| Description | llCastRay V3 sometimes reports:
2015-05-23 08:31:36,116 WARN - OpenSim.Region.Framework.Scenes.SceneGraph [SCENEGRAPH]: Problem processing action in ForEachSOG: An element with the same key already exists in the dictionary. at System.Collections.Generic.Dictionary`2[System.UInt64,OpenMetaverse.Rendering.FacetedMesh].Add (UInt64 key, OpenMetaverse.Rendering.FacetedMesh value) [0x00000] in <filename unknown>:0
at OpenSim.Region.ScriptEngine.Shared.Api.LSL_Api+<llCastRayV3>c__AnonStorey10.<>m__0 (OpenSim.Region.Framework.Scenes.SceneObjectGroup group) [0x00632] in /home/opensim/git/opensim/opensim/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs:14341
at OpenSim.Region.Framework.Scenes.SceneGraph.ForEachSOG (System.Action`1 action) [0x0001f] in /home/opensim/git/opensim/opensim/OpenSim/Region/Framework/Scenes/SceneGraph.cs:1158
This happens when several threads almost simultaneously creates and tries to add a missing geometry mesh to the mesh cache, so the mesh isn't in cache when they look for it but has been added before they have created and try to add it.
|
| Steps To Reproduce | Setup several llCastRay scripts to cast rays through the same prim, sculpt or mesh. Trigger them as simultaneously as possible, e.g. by restarting the sim. Often but not always the above error is reported then. |
| Additional Information | Mono 3.12.1 |
| Tags | No tags attached. |
|
| Git Revision or version number | 0.8.2 dev |
| Run Mode | Grid (1 Region per Sim) |
| Physics Engine | BulletSim |
| Environment | Mono / Linux32 |
| Mono Version | Other |
| Viewer | Singularity 1.8.6 OS X |
|
| Attached Files |  0001-Fix-mesh-cache-race-condition-in-llCastRay-V3.patch [^] (1,810 bytes) 2015-05-23 05:16 [Show Content] [Hide Content]From 459ca84fcd4594b6a7b70076cabc1732703c8c74 Mon Sep 17 00:00:00 2001
From: Magnuz Binder <magnuz@magnuz-se.com>
Date: Sat, 23 May 2015 13:48:37 +0200
Subject: [PATCH] Fix mesh cache race condition in llCastRay V3.
---
OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs b/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
index e769834..c5e02a6 100644
--- a/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
+++ b/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
@@ -14318,7 +14318,8 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
{
lock(m_cachedMeshes)
{
- m_cachedMeshes.Add(meshKey, mesh);
+ if (!m_cachedMeshes.ContainsKey(meshKey))
+ m_cachedMeshes.Add(meshKey, mesh);
}
}
}
@@ -14395,7 +14396,8 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
{
lock(m_cachedMeshes)
{
- m_cachedMeshes.Add(meshKey, mesh);
+ if (!m_cachedMeshes.ContainsKey(meshKey))
+ m_cachedMeshes.Add(meshKey, mesh);
}
}
}
--
1.9.1
|
|
Relationships 
Relationships 