Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0007510opensim[REGION] Script Functionspublic2015-03-22 00:262015-04-07 23:23
ReporterMagnuz 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Statuspatch includedResolutionopen 
PlatformIntel Core i7OSUbuntuOS Version12.04
Product Versionmaster (dev code) 
Target VersionFixed in Version 
Summary0007510: Constants scattered in LSL_Api
DescriptionThere are quite a few constants scattered throughout the LSL_Api. According to Robert Adams it would be better if at least some of them were parameterized. This is a first crack at that, starting with the 63 sleep constants, since they were the easiest to inventory. If there is any interest in continued work on this, I need pointers on documentation, directives or preferrably examples on naming, placing and use of parameters for e.g. limits and clipping.

Added: 69 constants used for limits and clamping have also been parameterized and added to config.
TagsNo tags attached.
Git Revision or version number0.8.2
Run Mode Grid (1 Region per Sim)
Physics EngineBulletSim
EnvironmentMono / Linux32
Mono Version2.10
ViewerFirestorm 4.4.2 for OS X
Attached Filespatch file icon 0001-Parameterize-sleeps-in-LSL-functions.patch [^] (26,956 bytes) 2015-03-22 05:48 [Show Content]
patch file icon 0001-Add-LSL-function-sleep-parameters-to-config.patch [^] (10,963 bytes) 2015-03-22 12:02 [Show Content]
patch file icon 0001-Parameterize-constants-in-LSL_Api-and-make-conf.patch [^] (57,190 bytes) 2015-03-23 14:18 [Show Content]
patch file icon 0001-Use-Util.Clamp-in-LSL_Api.patch [^] (22,714 bytes) 2015-03-24 10:40 [Show Content]
patch file icon 0001-Parameterize-more-constants-in-LSL_Api-and-make-conf.patch [^] (14,885 bytes) 2015-04-06 15:08 [Show Content]

- Relationships

-  Notes
(0027930)
Magnuz (reporter)
2015-03-22 00:27

Patch parameterizes all sleep constants in LSL_Api.
(0027937)
Robert Adams (administrator)
2015-03-22 10:30

Patch applied to master on 20150322.
(0027938)
Magnuz (reporter)
2015-03-22 12:08

Second patch (0001-Add-LSL-function-sleep-parameters-to-config.patch) adds the sleep parameters to configuration and reads them from there. Please check so I understood Robert Adams' instructions in Mantis 7509 right since I'm still noob at this.
(0027939)
Magnuz (reporter)
2015-03-23 14:20

Third patch (0001-Parameterize-constants-in-LSL_Api-and-make-conf.patch) parameterizes and adds relevant constants in LSL_Api to configuration, reading them from there.
(0027941)
Magnuz (reporter)
2015-03-24 10:47

Fourth patch (0001-Use-Util.Clamp-in-LSL_Api.patch) replaces a bit awkward clamping with a more elegant clamping function, and fixes the type of several limit parameters.

Parameters stored in vectors are doubles, while those stored in scalars are floats, something the previous clamping handled gracefully, but not the clamping function, hence the changing of many types.

This patch hasn't really got with the constants to do, but depends on the previous patches and tidies up the code some (8 lines of comparisons are replaced by a 1 line function call).
(0027942)
Magnuz (reporter)
2015-03-25 11:17

Fifth patch (0001-Parameterize-more-constants-in-LSL_Api-and-make-conf.patch) parametrizes and adds more constants in LSL_Api to configuration, reading them from there. This is hopefully the last major part in parameterizing the constants in LSL_Api, even if some tidying up after it might be needed.
(0027987)
Magnuz (reporter)
2015-04-07 23:23

I discovered a malformed parameter value in OpenSimDefaults.ini (a trailing " ***" flag left by mistake) passed the test suite despite it prevented XEngine from running live. I updated the patch for it, but it might be an idea to add a regression test for it.

- Issue History
Date Modified Username Field Change
2015-03-22 00:26 Magnuz New Issue
2015-03-22 00:26 Magnuz File Added: 0001-Parameterize-sleeps-in-LSL-functions.patch
2015-03-22 00:27 Magnuz Note Added: 0027930
2015-03-22 00:27 Magnuz Status new => patch included
2015-03-22 05:14 Magnuz File Added: 0002-Parameterize-sleeps-in-LSL-functions.patch
2015-03-22 05:15 Magnuz File Deleted: 0001-Parameterize-sleeps-in-LSL-functions.patch
2015-03-22 05:48 Magnuz File Added: 0001-Parameterize-sleeps-in-LSL-functions.patch
2015-03-22 05:49 Magnuz File Deleted: 0002-Parameterize-sleeps-in-LSL-functions.patch
2015-03-22 10:30 Robert Adams Note Added: 0027937
2015-03-22 12:02 Magnuz File Added: 0001-Add-LSL-function-sleep-parameters-to-config.patch
2015-03-22 12:08 Magnuz Note Added: 0027938
2015-03-23 14:18 Magnuz File Added: 0001-Parameterize-constants-in-LSL_Api-and-make-conf.patch
2015-03-23 14:20 Magnuz Note Added: 0027939
2015-03-23 14:24 Magnuz Summary Sleep constants scattered in LSL_Api => Constants scattered in LSL_Api
2015-03-23 14:24 Magnuz Description Updated View Revisions
2015-03-24 10:40 Magnuz File Added: 0001-Use-Util.Clamp-in-LSL_Api.patch
2015-03-24 10:47 Magnuz Note Added: 0027941
2015-03-25 11:11 Magnuz File Added: 0001-Parameterize-more-constants-in-LSL_Api-and-make-conf.patch
2015-03-25 11:17 Magnuz Note Added: 0027942
2015-04-06 15:08 Magnuz File Deleted: 0001-Parameterize-more-constants-in-LSL_Api-and-make-conf.patch
2015-04-06 15:08 Magnuz File Added: 0001-Parameterize-more-constants-in-LSL_Api-and-make-conf.patch
2015-04-07 23:23 Magnuz Note Added: 0027987


Copyright © 2000 - 2012 MantisBT Group
Powered by Mantis Bugtracker