0007503: Estate ban request raise exception - banned user data not written to database

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0007503

opensim

[REGION] Specific OpenSim Module

public

2015-03-16 04:45

2015-06-24 03:51

Reporter

Gavin Hird

Assigned To

Priority

normal

Severity

major

Reproducibility

always

Status

patch included

Resolution

open

Platform

OS Version

Product Version

master (dev code)

Target Version

Fixed in Version

Summary

0007503: Estate ban request raise exception - banned user data not written to database

Description

Trying to ban Vladimir Putin (!) after discovering he was on a copybot mission, using the Estate ban function in both Singularity and Kokua, raised to the exception as seen in the log below. The banned avatar was not added to the database.

2015-03-16 12:07:45,278 DEBUG - OpenSim.Region.CoreModules.Framework.UserManagement.UserManagementModule [USER MANAGEMENT MODULE]: HandleAvatarPickerRequest for vladimir
2015-03-16 12:07:48,243 WARN - OpenSim.Region.ClientStack.LindenUDP.LLClientView [LLCLIENTVIEW]: EstateOwnerMessage: Unknown method kickestate requested for Gavin Hird in andwest
2015-03-16 12:07:48,244 DEBUG - OpenSim.Region.ClientStack.LindenUDP.LLClientView [LLCLIENTVIEW]: Param 0=92dc8763-8111-4628-aabb-5da5a4b79d71
2015-03-16 12:08:02,301 DEBUG - OpenSim.Region.CoreModules.Framework.UserManagement.UserManagementModule [USER MANAGEMENT MODULE]: HandleAvatarPickerRequest for vladimir
2015-03-16 12:08:09,098 ERROR - OpenSim.Region.ClientStack.LindenUDP.LLClientView [LLCLIENTVIEW]: Caught exception while processing OpenMetaverse.Packets.EstateOwnerMessagePacket for Gavin Hird, Can't cast OpenMetaverse.UUID into any valid DbType. at Npgsql.NpgsqlParameter.set_Value (System.Object value) [0x00000] in <filename unknown>:0
  at Npgsql.NpgsqlParameter..ctor (System.String parameterName, System.Object value) [0x00000] in <filename unknown>:0
  at (wrapper remoting-invoke-with-check) Npgsql.NpgsqlParameter:.ctor (string,object)
  at Npgsql.NpgsqlParameterCollection.AddWithValue (System.String parameterName, System.Object value) [0x00000] in <filename unknown>:0
  at (wrapper remoting-invoke-with-check) Npgsql.NpgsqlParameterCollection:AddWithValue (string,object)
  at OpenSim.Data.PGSQL.PGSQLEstateStore.GetEstatesByOwner (UUID ownerID) [0x00000] in <filename unknown>:0
  at OpenSim.Services.Connectors.EstateDataService.GetEstatesByOwner (UUID ownerID) [0x00000] in <filename unknown>:0
  at OpenSim.Region.CoreModules.World.Estate.EstateManagementModule.handleEstateAccessDeltaRequest (IClientAPI remote_client, UUID invoice, Int32 estateAccessType, UUID user) [0x00000] in <filename unknown>:0
  at OpenSim.Region.ClientStack.LindenUDP.LLClientView.HandleEstateOwnerMessage (IClientAPI sender, OpenMetaverse.Packets.Packet Pack) [0x00000] in <filename unknown>:0
  at OpenSim.Region.ClientStack.LindenUDP.LLClientView.ProcessSpecificPacketAsync (System.Object state) [0x00000] in <filename unknown>:0

Steps To Reproduce

See above

Tags

No tags attached.

Git Revision or version number

Run Mode

Grid (Multiple Regions per Sim)

Physics Engine

BulletSim

Script Engine

Environment

Mono / OSX

Mono Version

trunk

Viewer

Singularity, Kokua

Attached Files

PGSQLEstateData.cs [^] (23,118 bytes) 2015-06-24 03:11

Relationships

related to	0007604	patch included		DeleteClassifiedRecord exception PGSQL
related to	0007606	closed	orenh	Group handler exception - PGSQL

Notes
(0028793) Gavin Hird (reporter) 2015-06-24 03:15	Line 503 had "EstateID" misspelled, so that is corrected in the attached file. This is a partial fix in that it will Add and Delete an avatar to the estate ban list using the "This Estate" viewer button (default button), while it will throw the exception using the "All Estates" button. I am unsure if the "All Estates" even work for MySQL as the code section looks identical in MySQLEstateData.cs It needs to be verified.

(0028798) dahlia (administrator) 2015-06-24 03:51	Thanks for the fix. I don't use Pgsql so I can't test it but the changes appear small and simple enough. We prefer to use patches formatted for git but since the changes are small I can just accept them as you uploaded them. You also might want to consider using git formatted patches in the future as it will preserve version and author history. I applied your changes in commit r2c5a3ff9f0c2. PGSQL users, please test and comment.

Issue History
Date Modified	Username	Field	Change
2015-03-16 04:45	Gavin Hird	New Issue
2015-06-06 12:26	Gavin Hird	Relationship added	related to 0007604
2015-06-24 03:11	Gavin Hird	File Added: PGSQLEstateData.cs
2015-06-24 03:15	Gavin Hird	Note Added: 0028793
2015-06-24 03:15	Gavin Hird	Status	new => patch included
2015-06-24 03:17	Gavin Hird	Relationship added	related to 0007606
2015-06-24 03:51	dahlia	Note Added: 0028798