Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0007335opensim[GRID] Hypergridpublic2014-09-29 03:382014-10-08 15:21
ReporterAliciaRaven 
Assigned Tojustincc 
PrioritynormalSeverityminorReproducibilityalways
Statuspatch feedbackResolutionopen 
PlatformOSOS Version
Product Versionmaster (dev code) 
Target VersionFixed in Version 
Summary0007335: [Patch] Fix restricted appearance checks not called for landmark teleports
DescriptionWhen RestrictAppearanceAbroad is enabled for EntityTransferModule, the check is only performed when the hg teleport is initiated from the map. If a landmark is used the checks are not done. This patch fixes this by adding the same call to landmark teleports that already exist in the main teleport code.

The checking method (ValidateGenericConditions) is passed teleport flags that are not used. I didn't change that but maybe it should be?

Another thing i noticed is that while appearance is checked when teleporting out, when the user gets to the remote grid, they can still change appearance even when RestrictAppearanceAbroad and RestrictInventoryAccessAbroad are both enabled. Inventory is only restricted for prims, all others seem to work ok. Again this is not addressed in this patch, just some thing i noticed while looking through the code.

Thanks :)
TagsNo tags attached.
Git Revision or version number
Run Mode Grid (Multiple Regions per Sim)
Physics EngineBulletSim
Script Engine
EnvironmentUnknown
Mono VersionNone
Viewer
Attached Filespatch file icon 0001-HG-Restricted-appearance-checking-code-is-only-calle.patch [^] (1,810 bytes) 2014-09-29 03:38 [Show Content]

- Relationships

-  Notes
(0026887)
justincc (administrator)
2014-10-08 15:21

Thanks Alicia. Committed as git master a83f5f2. I also made a subsequent change in 458ccd2 to simplify the code as we can now know the clients are always in the same scene as the module (previously before 459c763 the module was shared between all scenes).

tbh, I suspect the code could be refactored so that there can be a single point where the conditions are checked but I don't know that for sure yet.

Regarding the flags, I think that it's reasonable to pass these in even though they are not currently used. It's the kind of data you might want to perform subsequent checks.

Regarding the appearance restriction stuff, I'm not familiar with the mechanisms but I suspect that this is an oversight/problem.

- Issue History
Date Modified Username Field Change
2014-09-29 03:38 AliciaRaven New Issue
2014-09-29 03:38 AliciaRaven File Added: 0001-HG-Restricted-appearance-checking-code-is-only-calle.patch
2014-09-29 03:40 AliciaRaven Status new => patch included
2014-10-08 15:21 justincc Note Added: 0026887
2014-10-08 15:21 justincc Assigned To => justincc
2014-10-08 15:21 justincc Status patch included => patch feedback


Copyright © 2000 - 2012 MantisBT Group
Powered by Mantis Bugtracker