Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0006748opensim[REGION] OpenSim Corepublic2013-08-26 09:182014-05-21 03:36
Reporteraiaustin 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusnewResolutionopen 
PlatformPCOSWindowsOS Version7
Product Versionmaster (dev code) 
Target VersionFixed in Version 
Summary0006748: Are two character names allowed for regions?
DescriptionI created a region named "AI" with the two character region name on OSGrid, and that seemed to work fine.

But Firestorm 4.4.2 for me for example says I need three character search string.

Grid: Use a search string with at least 3 characters

Does that message come from the viewer of the underlying OpenSim server side? If its meant to be a restriction we might want to limit create region to NOT allow shorter names maybe?
TagsNo tags attached.
Git Revision or version numberr/23496
Run Mode Grid (Multiple Regions per Sim)
Physics EngineBulletSim
Script Engine
Environment.NET / Windows64
Mono VersionNone
ViewerFirestorm 4.4.2 OS
Attached Files

- Relationships

-  Notes
(0024289)
Mata Hari (reporter)
2013-08-26 20:58

When I tested doing a map search for this I got the same message and I saw no activity at all in the console so presumably this is a hard-coded viewer restriction (likely common to all viewers) for searches and never gets sent to the sim.

I suppose one could use this as a "feature" by having a "welcome" region that people can search for and tp to, and then a series of 2-character neighbouring regions that could only be accessed by first going to the welcome one or by using a landmark. :P But more seriously...yeah, probably worth at least warning people to make 3-character region names.
(0024291)
aiaustin (developer)
2013-08-27 00:25
edited on: 2013-08-27 02:06

If we establish its not a server side restriction, the better approach is to remove any hard coded limit on region name search strings in the viewers that have OpenSim variants (like Firestorm).

I reported this to the Firestorm JIRA at

http://jira.phoenixviewer.com/browse/FIRE-11479 [^]

I note that Singularity Viewer 1.8.1 allows any length search term... so "a" shows all regions whose names begin with "a" or "A" and "AI" shows the region "AI on OSGrid fine, so this must be a limitation in other viewers.

(0024302)
justincc (administrator)
2013-08-29 15:44

I think this is likely to be a viewer restriction. As far as I know, there is no region length name restriction in OpenSimulator.
(0024304)
SignpostMarv (reporter)
2013-08-29 16:03

Does that mean we can have a region named "" i.e. String.Empty ?
(0024305)
justincc (administrator)
2013-08-29 16:06

I suspect OpenSimulator may allow that though I think it's the kind of name you'd choose if you wanted to try and break things :)
(0024634)
aiaustin (developer)
2013-11-09 01:45

At 04:30 09/11/2013, Cinder Biscuits (JIRA) wrote:
Cinder Biscuits updated Improvement FIRE-11479 - Map Tool - Inappropriate limitation on search for OpenSim region names to use at least 3 characters

After looking into this, it appears there is no limit to the search query in the Firestorm viewer. The minimum 3 character limit is a message sent from the simulator denying the query, and yes, in fact, Singularity plays by the exact same rules.

Closing this Firestorm viewer issue as out of scope. The limit is set in the simulator not the viewer.
(0024635)
aiaustin (developer)
2013-11-09 01:47
edited on: 2013-11-15 06:59

It does seems that OpenSim itself is for some reason imposing a shortest search string limit for looking up region names in the map too in viewers.

This is a pain as it stops some short named regions (e.g. we have one called "AI") being found in the map to allow for a teleport via the map.

Cinders looked at this in Firestorm and Singularity and they impose no such restriction, it comes form the simulator itself.

I have seen comments that short search terms can impose an unreasonable load on large grids as they find all the relevant regions for a short search term... but not being able to find a region at all is more serious.

I wonder if the string can be changed from min 3 to min 2 characters? Or indeed even made configurable with a default, but changeable for grids that have short region names?

It would make sense for the SAME limit (as in force at any time) to apply as a test when regions are created or loaded to warn that the region name may not be found in search at the limit set.

(0026150)
aiaustin (developer)
2014-05-21 03:36
edited on: 2014-05-21 09:37

I wonder if we can amend the hardwired minimum search string length for map tool searches.. in the module Oren was just improving for wildcard searches.... the 2 character length named regions, e.g. on OSGrid, and yes such names are legal and allowed in OpenSim, simply cannot be found in search at present, which is an inconsistency.

Temporarily can we amend the minimum from 3 to 2? But if its an issue for some grid with lots of regions, consider making that be a changeable .ini file parameter? That would also allow the same minimum to be applied as a check when a region name is first created too for consistency?

It may just needs a tiny change in

OpenSim/Region/CoreModules/World/WorldMap/MapSearchModule.cs

to amend this line below to have <2 and <3

if (mapName.Length < 3 || (mapName.EndsWith("#") && mapName.Length < 4))

and error message just below that saying search string should be less than 3 characters needs changing to 2.


- Issue History
Date Modified Username Field Change
2013-08-26 09:18 aiaustin New Issue
2013-08-26 09:19 aiaustin Description Updated View Revisions
2013-08-26 20:58 Mata Hari Note Added: 0024289
2013-08-27 00:25 aiaustin Note Added: 0024291
2013-08-27 00:33 aiaustin Note Edited: 0024291 View Revisions
2013-08-27 00:33 aiaustin Description Updated View Revisions
2013-08-27 02:06 aiaustin Note Edited: 0024291 View Revisions
2013-08-29 15:44 justincc Note Added: 0024302
2013-08-29 16:03 SignpostMarv Note Added: 0024304
2013-08-29 16:06 justincc Note Added: 0024305
2013-11-09 01:45 aiaustin Note Added: 0024634
2013-11-09 01:47 aiaustin Note Added: 0024635
2013-11-15 06:59 aiaustin Note Edited: 0024635 View Revisions
2014-05-21 03:36 aiaustin Note Added: 0026150
2014-05-21 09:37 aiaustin Note Edited: 0026150 View Revisions


Copyright © 2000 - 2012 MantisBT Group
Powered by Mantis Bugtracker