Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0006680opensim[REGION] OpenSim Corepublic2013-06-16 10:182013-07-04 10:52
Reporterkcozens 
Assigned Tokcozens 
PrioritynormalSeverityminorReproducibilityalways
Statuspatch feedbackResolutionopen 
PlatformOSOS Version
Product Versionmaster (dev code) 
Target VersionFixed in Version 
Summary0006680: Any group update clears all cached group data
DescriptionWhile working on an issue related to groups I discovered that an update (not a get function) for any group clear ALL cached group data. Only the cached data for the group being updated should be cleared.

I have attached a patch that fixes this issue. It also moves a hard-coded timeout value in to a variable so it would be easy to provide a means to change the timeout value via a configuration option sometime in the future.
TagsNo tags attached.
Git Revision or version number694c4bcbb671338263802457bb5a384c4fe44d26
Run Mode Grid (1 Region per Sim)
Physics EngineBulletSim
Script Engine
EnvironmentUnknown
Mono VersionNone
Viewer
Attached Filespatch file icon 0002-Don-t-clear-all-cached-group-data-when-data-for-a-si.patch [^] (3,063 bytes) 2013-06-16 10:18 [Show Content]

- Relationships

-  Notes
(0024145)
justincc (administrator)
2013-06-26 16:23

I've no doubt that the efficiency could be improved by not wiping the entire cache for various calls but on code inspection I don't quite see how this particular patch would work. For instance, if the UpdateGroup() method made the function call "groups.updateGroup", the CacheKey created would not clear the "groups.getGroup" cache key which could be used later for that group.

Moving the timeout to a parameter is fine and could be committed as a separate patch if necessary.
(0024184)
kcozens (administrator)
2013-07-04 10:52

Having thought about the comment about the cache key for a while I see the problem mentioned by justincc. Combining the agent ID and the function call to make the cache key seems a poor choice. To do that properly would require mapping the full set of function calls to a smaller set for use as part of the key. A better key might be the agent ID combined with the group ID.

- Issue History
Date Modified Username Field Change
2013-06-16 10:18 kcozens New Issue
2013-06-16 10:18 kcozens File Added: 0002-Don-t-clear-all-cached-group-data-when-data-for-a-si.patch
2013-06-16 10:25 kcozens Assigned To => kcozens
2013-06-16 10:25 kcozens Status new => patch included
2013-06-26 16:23 justincc Note Added: 0024145
2013-06-26 16:23 justincc Status patch included => patch feedback
2013-07-04 10:52 kcozens Note Added: 0024184


Copyright © 2000 - 2012 MantisBT Group
Powered by Mantis Bugtracker