Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0006284opensim[REGION] Scripting Enginepublic2012-09-10 04:322012-09-11 02:13
ReporterSignpostMarv 
Assigned Tomelanie 
PrioritylowSeveritytextReproducibilityN/A
Statuspatch includedResolutionopen 
PlatformOSOS Version
Product Versionmaster (dev code) 
Target VersionFixed in Version 
Summary0006284: formatting for MOD_Api.ConvertFromLSL
DescriptionAttached patch applies some formatting to make the syntax more consistent with itself and add line breaks to be friendly with `git commit -p` output and other 80-character terminal displays.
TagsNo tags attached.
Git Revision or version number
Run Mode Grid (1 Region per Sim)
Physics EngineBasicPhysics
Script Engine
Environment.NET / Windows32
Mono VersionNone
Viewer
Attached Filespatch file icon mod-ConvertFromLSL-formatting.patch [^] (6,360 bytes) 2012-09-10 04:32 [Show Content]
patch file icon mod-ConvertFromLSL-formatting-redux.patch [^] (5,354 bytes) 2012-09-10 06:36 [Show Content]
patch file icon mantis-6284-rebased-cherry-picked.patch [^] (5,354 bytes) 2012-09-11 02:12 [Show Content]

- Relationships

-  Notes
(0022574)
melanie (administrator)
2012-09-10 05:29

If a statement in an if/else clause needs to be broken so it becomes more than one line, then that statement must be in braces. The rule is that statements that take up only ONE LINE require no braces. The criterion is "one line of source code", not "one statement".

Please fix.
(0022575)
SignpostMarv (reporter)
2012-09-10 05:30

ah, understood. Will fix shortly, testing another unrelated patch.
(0022578)
SignpostMarv (reporter)
2012-09-10 06:36
edited on: 2012-09-10 06:37

Redid the patch to be applied after 0006285, also made the commit messages less nonsensical.

(0022584)
SignpostMarv (reporter)
2012-09-11 02:13

Redid the patch to be applied after 0006285 again, just in case.

- Issue History
Date Modified Username Field Change
2012-09-10 04:32 SignpostMarv New Issue
2012-09-10 04:32 SignpostMarv File Added: mod-ConvertFromLSL-formatting.patch
2012-09-10 04:33 SignpostMarv Relationship added child of 0006283
2012-09-10 04:33 SignpostMarv Status new => patch included
2012-09-10 05:29 melanie Note Added: 0022574
2012-09-10 05:30 melanie Assigned To => melanie
2012-09-10 05:30 melanie Status patch included => patch feedback
2012-09-10 05:30 SignpostMarv Note Added: 0022575
2012-09-10 06:32 SignpostMarv Relationship deleted child of 0006283
2012-09-10 06:36 SignpostMarv File Added: mod-ConvertFromLSL-formatting-redux.patch
2012-09-10 06:36 SignpostMarv Note Added: 0022578
2012-09-10 06:37 SignpostMarv Note Edited: 0022578 View Revisions
2012-09-10 07:10 SignpostMarv Status patch feedback => patch included
2012-09-11 02:12 SignpostMarv File Added: mantis-6284-rebased-cherry-picked.patch
2012-09-11 02:13 SignpostMarv Note Added: 0022584


Copyright © 2000 - 2012 MantisBT Group
Powered by Mantis Bugtracker