| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] |
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0006231 | opensim | [GRID] Grid Service | public | 2012-08-20 13:43 | 2012-08-20 13:43 |
|
| Reporter | SignpostMarv | |
| Assigned To | | |
| Priority | low | Severity | minor | Reproducibility | always |
| Status | new | Resolution | open | |
| Platform | | OS | | OS Version | |
| Product Version | master (dev code) | |
| Target Version | | Fixed in Version | | |
|
| Summary | 0006231: Searching the map triggers a "Hyperlink could not be established" message for strings that aren't hyperlink URIs |
| Description | Just a minor annoyance, if I'm search the grid map and make a typo, I get an alert that says "Hyperlink could not be established". This would be fine if I was search for hypergrid URIs, but sometimes I'm not. |
| Tags | No tags attached. |
|
| Git Revision or version number | |
| Run Mode | Standalone (1 Region) , Grid (1 Region per Sim) |
| Physics Engine | BasicPhysics |
| Environment | Unknown |
| Mono Version | None |
| Viewer | |
|
| Attached Files | MapSearchHyperlinkAnnoyance.patch [^] (1,388 bytes) 2012-08-20 13:43 [Show Content] [Hide Content]From a56c3bfdf16d5d4c6871f89974bce0858d59e8fb Mon Sep 17 00:00:00 2001
From: SignpostMarv <github@signpostmarv.name>
Date: Mon, 20 Aug 2012 14:32:08 +0100
Subject: [PATCH] fixing an annoyance with the map search when one would be
alerted to no hyperlink being found when one did not search
for a hyperlink address
---
OpenSim/Region/CoreModules/World/WorldMap/MapSearchModule.cs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OpenSim/Region/CoreModules/World/WorldMap/MapSearchModule.cs b/OpenSim/Region/CoreModules/World/WorldMap/MapSearchModule.cs
index f37dd94..b9377e1 100644
--- a/OpenSim/Region/CoreModules/World/WorldMap/MapSearchModule.cs
+++ b/OpenSim/Region/CoreModules/World/WorldMap/MapSearchModule.cs
@@ -112,7 +112,7 @@ namespace OpenSim.Region.CoreModules.World.WorldMap
// try to fetch from GridServer
List<GridRegion> regionInfos = m_scene.GridService.GetRegionsByName(m_scene.RegionInfo.ScopeID, mapName, 20);
- if (regionInfos.Count == 0)
+ if (regionInfos.Count == 0 && System.Uri.IsWellFormedUriString(mapName, System.UriKind.Absolute))
remoteClient.SendAlertMessage("Hyperlink could not be established.");
m_log.DebugFormat("[MAPSEARCHMODULE]: search {0} returned {1} regions. Flags={2}", mapName, regionInfos.Count, flags);
--
1.7.11.msysgit.1
|
|