|Anonymous | Login | Signup for a new account||2013-06-20 01:31 UTC|
|Main | My View | View Issues | Change Log | Roadmap | Summary | My Account|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0006069||opensim||[REGION] OpenSim Core||public||2012-07-01 17:37||2012-07-02 17:59|
|Target Version||Fixed in Version|
|Summary||0006069: [Patch] Adds a list of viewers that are allowed or banned from regions.|
|Description||The patch adds 2 lists to the OpenSim.ini that allows one to only allow specific viewers listed to gain access to the region and a list for viewers that are banned from regions.|
The list uses substrings sothat one can select specific viewer versions if neccessary.
|Tags||No tags attached.|
|Git Revision or version number||6d3ee8bb39d47ed7b32e8905fa0b2fc31c5a9f80|
|Run Mode||Standalone (1 Region) , Standalone (Multiple Regions) , Grid (1 Region per Sim) , Grid (Multiple Regions per Sim)|
|Attached Files||004-[Patch] Adds-list-of-viewers-that-are-allowed-or-banned.patch [^] (5,333 bytes) 2012-07-02 17:12 [Show Content]|
Michelle Argus (reporter)
|Ups, I still had a info line in the patch which I removed in 002. Ignore 001|
|"Banned" is spelled with two N. Also, one needs to be aware that the string is entirely viewer supplied and the viewers have a command line option, --channel, which allows to set an arbitrary string here. That makes the feature as such completely useless for the intended purpose, since most griefer/copybot viewers already identify as Phoenix and those who use them usually know how to change this.|
|With that logic this feature is also useless on a grid level ... but the intention is quite different. We always have troubles at parties or other events when people join with strange alpha viwers. Parties are not the place to do viewer testing or building. The intention there is more for socializing and therefore stability and absence of chat lag is very important! Therefore this patch gets a huge +1 from me! Quote: LyAvain Swansong: Ich knutsch ihr die Füsse wenn sie das hinkriegt.|
Michelle Argus (reporter)
|corrected the missing n and added a note to the ini.example that griefers can change the viewers source code to get access anyway|
Patch failed to apply.
[root@grid00001 opensim-commit]# git am 003-%5BPatch%5D%20Adds-list-of-viewers-that-are-allowed-or-banned.patch
Applying: Adds a list of viewers that are allowed or banned from the region.
/home/root/opensim-git/.git/rebase-apply/patch:86: trailing whitespace.
fatal: corrupt patch at line 92
Patch failed at 0001.
Michelle Argus (reporter)
|Hope patch 004 fixes the problem...|
This patch also did not apply cleanly. Here is what the problems were:
Your paths in the patch read a/update/opensim/a/OpenSim/.... where they should be a/OpenSim/....
This indicates that you may have checked out one repo within another. That is legal in git, however, to create patches you must be in the inner repo. Maybe your path is like this: /some/dirs/myrepo/update/opensim/OpenSim/.... If so, you shoud be in /some/dirs/myepo/update/ when making the patch, not in /some/dirs/myrepo.
The patch contained DOS newlines (^M) which I had to remove manually. It would have introduced DOS newlines into the codebase, This is not acceptable. Please supply all future patches with correct Unix newlines.
Finally, you removed the --<space>\n--- marker from the end of the patch. Removing that marker corrupts the patch, please leave these two lines of dashes in next time around.
I had to add those lines, edit the paths and remove the DOS newlines to apply this patch, not something anyone wishes to do for every submissions.
|2012-07-01 17:37||Michelle Argus||New Issue|
|2012-07-01 17:37||Michelle Argus||File Added: 001-[Patch] Adds-list-of-viewers-that-are-allowed-or-banned.patch|
|2012-07-01 17:37||Michelle Argus||Status||new => patch included|
|2012-07-01 17:47||Michelle Argus||File Added: 002-[Patch] Adds-list-of-viewers-that-are-allowed-or-banned.patch|
|2012-07-01 17:48||Michelle Argus||Note Added: 0021724|
|2012-07-01 17:49||melanie||File Deleted: 001-[Patch] Adds-list-of-viewers-that-are-allowed-or-banned.patch|
|2012-07-01 17:51||melanie||Note Added: 0021725|
|2012-07-01 18:07||Akira||Note Added: 0021726|
|2012-07-01 18:10||Michelle Argus||File Added: 003-[Patch] Adds-list-of-viewers-that-are-allowed-or-banned.patch|
|2012-07-01 18:11||Michelle Argus||Note Added: 0021727|
|2012-07-01 19:23||melanie||File Deleted: 002-[Patch] Adds-list-of-viewers-that-are-allowed-or-banned.patch|
|2012-07-01 19:24||melanie||Assigned To||=> melanie|
|2012-07-01 19:24||melanie||Status||patch included => patch ready|
|2012-07-01 19:26||melanie||Note Added: 0021729|
|2012-07-01 19:26||melanie||Status||patch ready => patch feedback|
|2012-07-02 17:12||Michelle Argus||File Added: 004-[Patch] Adds-list-of-viewers-that-are-allowed-or-banned.patch|
|2012-07-02 17:13||Michelle Argus||Note Added: 0021734|
|2012-07-02 17:47||melanie||File Deleted: 003-[Patch] Adds-list-of-viewers-that-are-allowed-or-banned.patch|
|2012-07-02 17:59||melanie||Note Added: 0021735|
|2012-07-02 17:59||melanie||Note Added: 0021736|
|2012-07-02 17:59||melanie||Status||patch feedback => resolved|
|2012-07-02 17:59||melanie||Resolution||open => fixed|
|Copyright © 2000 - 2012 MantisBT Group|