Main | My View | View Issues | Change Log | Roadmap | Summary | Docs | My Account
  

Viewing Issue Simple Details [ Jump to Notes ] [ View Advanced ] [ Issue History ] [ Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0004329 [opensim] [REGION] Script Functions minor always 2009-10-29 09:00 2010-02-15 18:42
Reporter aduffy70 View Status public  
Assigned To jhurliman
Priority normal Resolution fixed  
Status closed   Product Version master (dev code)
Summary 0004329: llDialog fails silently
Description Scripts using llDialog no longer function on recent versions. The scripts compile, and there is no error message, but no dialog box is produced. Could this be related to the recent change (66923983) that eliminated the "Script Compiled Successfully" popup box?
Additional Information It seems it is only dialog boxes with an empty "buttons" list that fail...
This works:
touch_start(integer num)
    {
        key ToucherID = llDetectedKey(0);
        llDialog(ToucherID, "test", ["1","2"], 713);
    }

This does not:
touch_start(integer num)
    {
        key ToucherID = llDetectedKey(0);
        llDialog(ToucherID, "test", [], 713);
    }

In builds from late september, both worked fine.
Tags No tags attached.
Git Revision 2c34619
SVN Revision 0
Run Mode Standalone (1 Region)
Physics Engine ODE
Environment Mono / Linux32
Mono Version 2.4.2
Attached Files ? file icon 0012-Sanity-checks-packet-splitting-results-in-LLUDPServe.patch [^] (1,211 bytes) 2009-10-29 22:19

- Relationships

-  Notes
(0014009)
aduffy70 (reporter)
2009-10-29 11:48

 This might be part of something larger. I notice that calls to the IDialogModule.SendGeneralAlert() method from region modules have stopped working since late September versions as well.
(0014013)
dslake (manager)
2009-10-29 20:20

 I did some poking around on this issue.

The "compile successful" message came from OpenSim\Region\ScriptEngine\DotNetEngine\ScriptManager.cs but that file was removed in r11361 along with the rest of the DotNetEngine support.

The mechanism it used was to send an AgentAlertMessage packet to the viewer through a call to the controlling agent SendAgentAlertMessage function.

The llDialog command on the other hand uses a ScriptDialog packet type, generated by a call to the controlling agent SendDialog function.

The removal of DotNetEngine may have impacted the dialog boxes, but they don't seem related from the code changes.
(0014014)
melanie (administrator)
2009-10-29 20:24

 Actually, "Compile successful" was in two places. I removed it from XEngine, but didn't bother to remove it from DNE, since it's removal was already decided at that time.
It's unrelated to the llDialog issue.
(0014017)
dslake (manager)
2009-10-29 22:05

 The problem has been identified as a bug in libomv's ToBytesMultiple() function. Please see the bug report at:

http://jira.openmv.org/browse/LIBOMV-737 [^]
(0014018)
dslake (manager)
2009-10-29 22:20

 The patch does not fix the problem. The right place to fix it is in libomv. This will sanity check the results of splitting packets.
(0014019)
jhurliman (manager)
2009-10-30 00:10

 This should be fixed in ra05c67bebb8a. I also applied an equivalent patch for logging an error message if ToBytesMultiple() fails to return any packets.

- Issue History
Date Modified Username Field Change
2009-10-29 09:00 aduffy70 New Issue
2009-10-29 09:00 aduffy70 Git Revision => 2c34619
2009-10-29 09:00 aduffy70 SVN Revision => 0
2009-10-29 09:00 aduffy70 Run Mode => Standalone (1 Region)
2009-10-29 09:00 aduffy70 Physics Engine => ODE
2009-10-29 09:00 aduffy70 Environment => Mono / Linux32
2009-10-29 09:00 aduffy70 Mono Version => 2.4.2
2009-10-29 09:16 aduffy70 Additional Information Updated
2009-10-29 11:48 aduffy70 Note Added: 0014009
2009-10-29 20:20 dslake Note Added: 0014013
2009-10-29 20:24 melanie Note Added: 0014014
2009-10-29 22:05 dslake Note Added: 0014017
2009-10-29 22:19 dslake File Added: 0012-Sanity-checks-packet-splitting-results-in-LLUDPServe.patch
2009-10-29 22:20 dslake Note Added: 0014018
2009-10-29 22:20 dslake Status new => patch included
2009-10-30 00:10 jhurliman Note Added: 0014019
2009-10-30 00:10 jhurliman Assigned To => jhurliman
2009-10-30 00:10 jhurliman Status patch included => resolved
2009-10-30 00:10 jhurliman Resolution open => fixed
2010-02-15 18:42 chi11ken Status resolved => closed

Mantis 1.1.1[^]
Copyright © 2000 - 2008 Mantis Group
Powered by Mantis Bugtracker