0003313: [Patch] Additional features for the Sun module

(0010029)
melanie (administrator)
2009-03-19 12:31

This patch has two issues.

One, multiple set channel commands will cause multiple additions of the hook function, creating multiple calls to the parser and causing chat lag.
A single methid can be added to an event multiple times, and will be called that many times. Therefore, duplicate addition of a hander to an event must be guarded against.

Two, this is improper use of the console command system. A module wishing to provide a sub-command tree should use ICommandable, a module using add command should add each possible command and need not provide a help screen. This is integrated in the console itself.

In it's current form, -1

(0010031)
mcortez (developer)
2009-03-19 14:03
edited on: 2009-03-19 14:05

Where is the documentation for "proper use of the console command system" - I did not notice anything on the dev wiki.

This introduces at most, 3 console commands {get, set, list} -- the intent was this to be a single command, with three options for parameters, none, one and two.

The "system" that the terrain module is using looks extremely inefficient and heavy for what is a relatively simple activity.

(0010034)
mcortez (developer)
2009-03-19 14:55

Is V.5 of the patch what your looking for in re: to ICommandable?

(0010035)
melanie (administrator)
2009-03-19 15:12

yes. this should now appear as "sun - sun subcommands" in the help and allow "sun help" to be used via the module commander system
Another option would have been to have multipe add command, adding "sun set"and "sun get", which would make them separate main help options. Either way will work. The guard is in there, too, so

+1

(0010036)
mcortez (developer)
2009-03-19 15:28
edited on: 2009-03-19 15:33

I'm testing, and it doesn't look like doing "sun help" works, I get an invalid command. Do I have to implement the help myself? I thought the whole point of using the ICommandable thing was so that it would do it automatically?

--

Nevermind, the proper syntax is "help sun" not "sun help"

but there is still issues, because the functions that should be called by sun get and sun set don't seem to be getting called

(0010038)
melanie (administrator)
2009-03-19 15:42

I didn't check function, just api usage.

(0010041)
Ewe Loon (reporter)
2009-03-19 19:42

it appears that osGetCurrentSunHour() is returning the time offset by 6 hours,
e.g, 0.0 is at sun rise, 6.0 is when the sun it at highest position 12.0 is sunset
if this is surposed to be like this please let me know so i can correct my clocks to suit

(0010044)
mcortez (developer)
2009-03-20 07:44

That is the correct behavior of osGetCurrentSunHour().

The internal representation of the sun's position in Sun Module is based on 0 to 24 for a full day, with 0 being roughly run rise.

The estate settings also tracks zero hour as roughly sunrise.

The Region sun settings use the range 6 to 30, with 6 being roughly sun-rise,.

(0010052)
mcortez (developer)
2009-03-20 15:33

V.9 of the patch, enables context help for console but chat capability was removed.

(0010053)
svn (developer)
2009-03-20 15:42

melanie committed related code in r8829

Thank you, mcortez, for patch to add functionality to the sun module.
Fixes Mantis 0003313

see more at - http://opensimulator.org/cgi-bin/viewvc.cgi?view=rev&revision=8829 [^]

Issue History
Date Modified	Username	Field	Change
2009-03-19 12:22	mcortez	New Issue
2009-03-19 12:22	mcortez	File Added: sundeux.4.patch
2009-03-19 12:22	mcortez	SVN Revision	=> 0
2009-03-19 12:22	mcortez	Run Mode	=> Standalone (1 Region) , Standalone (Multiple Regions) , Grid (1 Region per Sim) , Grid (Multiple Regions per Sim)
2009-03-19 12:22	mcortez	Physics Engine	=> BasicPhysics, PhysicsOfSimplicity, ODE, BulletX, PhysX
2009-03-19 12:22	mcortez	Environment	=> Mono / Linux32
2009-03-19 12:22	mcortez	Mono Version	=> Other
2009-03-19 12:22	mcortez	Status	new => patch included
2009-03-19 12:31	melanie	Note Added: 0010029
2009-03-19 12:31	melanie	Status	patch included => patch feedback
2009-03-19 14:03	mcortez	Note Added: 0010031
2009-03-19 14:05	mcortez	Note Edited: 0010031
2009-03-19 14:54	mcortez	File Added: sundeux.5.patch
2009-03-19 14:55	mcortez	Note Added: 0010034
2009-03-19 15:12	melanie	Note Added: 0010035
2009-03-19 15:12	melanie	Status	patch feedback => patch ready
2009-03-19 15:28	mcortez	Note Added: 0010036
2009-03-19 15:29	mcortez	Note Added: 0010037
2009-03-19 15:29	mcortez	Status	patch ready => patch feedback
2009-03-19 15:31	mcortez	Note Deleted: 0010037
2009-03-19 15:32	mcortez	Note Edited: 0010036
2009-03-19 15:33	mcortez	Note Edited: 0010036
2009-03-19 15:42	melanie	Note Added: 0010038
2009-03-19 19:42	Ewe Loon	Note Added: 0010041
2009-03-20 07:44	mcortez	Note Added: 0010044
2009-03-20 15:31	mcortez	File Added: sundeux.9.nochat.patch
2009-03-20 15:33	mcortez	Note Added: 0010052
2009-03-20 15:42	svn	Checkin
2009-03-20 15:42	svn	Note Added: 0010053
2009-03-20 15:42	svn	Status	patch feedback => resolved
2009-03-20 15:42	svn	Resolution	open => fixed
2009-05-03 10:55	cfk	Status	resolved => closed

Notes
(0010029) melanie (administrator) 2009-03-19 12:31	This patch has two issues. One, multiple set channel commands will cause multiple additions of the hook function, creating multiple calls to the parser and causing chat lag. A single methid can be added to an event multiple times, and will be called that many times. Therefore, duplicate addition of a hander to an event must be guarded against. Two, this is improper use of the console command system. A module wishing to provide a sub-command tree should use ICommandable, a module using add command should add each possible command and need not provide a help screen. This is integrated in the console itself. In it's current form, -1

(0010031) mcortez (developer) 2009-03-19 14:03 edited on: 2009-03-19 14:05	Where is the documentation for "proper use of the console command system" - I did not notice anything on the dev wiki. This introduces at most, 3 console commands {get, set, list} -- the intent was this to be a single command, with three options for parameters, none, one and two. The "system" that the terrain module is using looks extremely inefficient and heavy for what is a relatively simple activity.

(0010034) mcortez (developer) 2009-03-19 14:55	Is V.5 of the patch what your looking for in re: to ICommandable?

(0010035) melanie (administrator) 2009-03-19 15:12	yes. this should now appear as "sun - sun subcommands" in the help and allow "sun help" to be used via the module commander system Another option would have been to have multipe add command, adding "sun set"and "sun get", which would make them separate main help options. Either way will work. The guard is in there, too, so +1

(0010036) mcortez (developer) 2009-03-19 15:28 edited on: 2009-03-19 15:33	I'm testing, and it doesn't look like doing "sun help" works, I get an invalid command. Do I have to implement the help myself? I thought the whole point of using the ICommandable thing was so that it would do it automatically? -- Nevermind, the proper syntax is "help sun" not "sun help" but there is still issues, because the functions that should be called by sun get and sun set don't seem to be getting called

(0010038) melanie (administrator) 2009-03-19 15:42	I didn't check function, just api usage.

(0010041) Ewe Loon (reporter) 2009-03-19 19:42	it appears that osGetCurrentSunHour() is returning the time offset by 6 hours, e.g, 0.0 is at sun rise, 6.0 is when the sun it at highest position 12.0 is sunset if this is surposed to be like this please let me know so i can correct my clocks to suit

(0010044) mcortez (developer) 2009-03-20 07:44	That is the correct behavior of osGetCurrentSunHour(). The internal representation of the sun's position in Sun Module is based on 0 to 24 for a full day, with 0 being roughly run rise. The estate settings also tracks zero hour as roughly sunrise. The Region sun settings use the range 6 to 30, with 6 being roughly sun-rise,.

(0010052) mcortez (developer) 2009-03-20 15:33	V.9 of the patch, enables context help for console but chat capability was removed.

(0010053) svn (developer) 2009-03-20 15:42	melanie committed related code in r8829 Thank you, mcortez, for patch to add functionality to the sun module. Fixes Mantis 0003313 see more at - http://opensimulator.org/cgi-bin/viewvc.cgi?view=rev&revision=8829 [^]

Relationships