 Notes |
(0009394)
melanie (administrator)
2009-02-12 17:44
|
Email reception is not implemented. Feel free to reopen this to submit a patch. Otherwise, I'm closing it to keep the list clean. |
|
(0009441)
DoranZemlja (reporter)
2009-02-14 11:40
|
adding patch; it does local mail delivery on the same region, and there are comments for hooks for region-to-region email |
|
(0009442)
Fly-Man- (developer)
2009-02-14 11:44
edited on: 2009-02-14 11:53
|
Please review this patch carefully,
Change Line 43 from:
Line 43:
+ m_InterObjectHostname = SMTPConfig.GetString("internal_object_host", "lsl.secondlife.com");
to:
Line 43:
+ m_InterObjectHostname = SMTPConfig.GetString("internal_object_host", "lsl.opensim.local");
|
|
(0009447)
melanie (administrator)
2009-02-14 13:23
|
There are a number of issues with this:
- Objects that havenever called llGetNextEmail should not have a queue, nor should email for them be saved at all
- Objects that have not called llGetNextEmail within 2 hours lose their email queue; what is in it gets deleted
- External email from objects contains no HTML, object email is always text only! LSL generates no HTML, so the remote mail implementation is wrong
- The local mail hostname needs to be a configuration option.
I'm still going to commit it, since it's an optional module that is not enabled by default, but I would like work on this to continue as outlined above and I willbe happy to commit any patches that aim to achieve this. |
|
(0009448)
svn (developer)
2009-02-14 13:25
|
melanie committed related code in r8394
Thank you, DoranZemlja, for a patch that implements local inter-object email
delivery.
Leaving Mantis 0003145 open so that more code can be added.
see more at - http://opensimulator.org/cgi-bin/viewvc.cgi?view=rev&revision=8394 [^]
|
|
(0009457)
DoranZemlja (reporter)
2009-02-14 15:31
|
Melanie --
Please note, original code (before my patch) did the HTML external email; I knew it wasn't right, but I left it unchanged for the external email case. I assumed whoever was before me had some good reason for it. |
|
(0009458)
melanie (administrator)
2009-02-14 15:33
|
It's wrong, since these emails are, 99%, machine parsed and the existing parsers will be broken by that HTML stuff.
Would be great if you could remove that when you continnue to work on it. |
|
(0009460)
DoranZemlja (reporter)
2009-02-14 16:34
|
added email2.patch
per Fly-Man's comment, changed default internal_object_host to lsl.opensim.local
per melanie's comment, moved queue creation to GetNextEmail and drop messages for objects with no queue. Also removed HTML from external emails, and expire inactive queues after 2 hours.
Local mail hostname was already a config option in previous patch. I updated OpenSim.ini.example to make this more clear. |
|
(0009461)
svn (developer)
2009-02-14 17:06
|
melanie committed related code in r8397
Thank you, DoranZemlja, for a patch that addresses some moe llGetNextEmail
issues.
Fixes Mantis 0003145.
see more at - http://opensimulator.org/cgi-bin/viewvc.cgi?view=rev&revision=8397 [^]
|
|
(0009462)
melanie (administrator)
2009-02-14 17:07
|
A point to think about: if lsl.secondlife.com is the default, then existing scripts will run unmodified, but scripts in OpenSim will not be able to communicate with objects in SL. If the default is something else, all scripts will need to be modified. |
|
email.patch [^] (11,886 bytes) 2009-02-14 11:41
