MantisBT - opensim
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0008558||opensim||[GRID] Grid Service||public||2019-07-06 02:34||2019-07-06 13:15|
|Target Version||Fixed in Version|
|Git Revision or version number|
|Run Mode||Standalone (1 Region) , Standalone (Multiple Regions) , Grid (1 Region per Sim) , Grid (Multiple Regions per Sim)|
|Viewer||Firestorm and Dayturn|
|Summary||0008558: hard_agent_limit in RegionInfo2 never initialized or updated|
|Description||There is an issue in recent builds of Firestorm and Dayturn which both have this patch implemented|
This patch adds HardMaxAgents / hard_agent_limit to RegionInfo2, but for OpenSim it is never initialized to anything as far as I can see despite being defined in LLClientView.cs, so the viewer gets garbage. It is also not included in GridService.cs public RegionData RegionInfo2RegionData(GridRegion rinfo)
hard_agent_limit is initialized to 100 in the viewer, so that is what the viewer will try to set and write back to the database.
As we have a variable in Regions.ini.example
; MaxAgents = 100
I suggest hard_agent_limit is initialized to 100 if unset in Regions.ini for a region, and given the value set for the region if present in Regions.ini
The above patch has not been taken for any current versions of Singularity, so it has the old, original behavior.
|Steps To Reproduce||Just to clarify, the hard_agent_limit sets the Max allowed value of the spinner in the input field "agent_limit_spin" in the form panel_region_general.xml|
The max value is initialized to 100 in the form itself, and on first view of the form also hard_agent_limit is initialized to 100, so the form seems to work ok.
After updating the field the first time and accepting the new value with the Apply button, the spinner field will be set to -1 the next time it is updated because at that time hard_agent_limit is being queried with the Region and is set to some random value that makes the code set it to -1, from then on the form us useless. This happens in llfloaterregioninfo.cpp in the viewer.
|Tags||No tags attached.|
|2019-07-06 02:34||Gavin Hird||New Issue|
|2019-07-06 02:34||Gavin Hird||Summary||hard_agent_limit in RegionInfo 2 never initialized or updated => hard_agent_limit in RegionInfo2 never initialized or updated|
|2019-07-06 03:23||Gavin Hird||Steps to Reproduce Updated||bug_revision_view_page.php?rev_id=8262#r8262|
|2019-07-06 11:51||UbitUmarov||Note Added: 0035452|
|2019-07-06 11:54||UbitUmarov||Note Edited: 0035452||bug_revision_view_page.php?bugnote_id=35452#r8264|
|2019-07-06 13:11||UbitUmarov||Note Added: 0035453|
|2019-07-06 13:14||Gavin Hird||Note Added: 0035454|
|2019-07-06 13:15||Gavin Hird||Note Edited: 0035454||bug_revision_view_page.php?bugnote_id=35454#r8266|
|2019-07-06 13:15||Gavin Hird||Status||new => resolved|