MantisBT - opensim
View Issue Details
0007747opensim[REGION] OpenSim Corepublic2015-11-22 04:302018-08-27 04:39
aiaustin 
 
normalmajoralways
acknowledgedopen 
PCWindows10
master (dev code) 
master (dev code) 
opensim-0.9.0-85-gf75d113
Standalone (Multiple Regions)
BasicPhysics
.NET / Windows64
None
N/A
0007747: LLoginService.cs login response has extra fields causing addon errors, plus question on special Radegast handling
At OpenSim\Services\LLLoginService\LLLoginService.cs there have been additional parameters added to the login response. This change causes addon packages which construct this response to give compilation errors. These will have to be changed by the addon developers, e.g. @Diva's Wifi.

In the definition of LoginResponse, since the avination merge, an extra bool parameter for "LibOMVclient" has been added. It may be worth checking if the LibOMVClient parameter is required, as looking at the code it seems to be there for special handling for the Radegast viewer. However, Radegast has always worked fine up to now without this special handling.

 
No tags attached.
Issue History
2015-11-22 04:30aiaustinNew Issue
2015-11-22 12:46aiaustinSummaryLLoginSerive.cs login response has extra bool LibOMVClient for Radegast clients since avination merge causing add on errors => LLoginService.cs login response has extra bool LibOMVClient for Radegast clients since avination merge causing add on errors
2015-11-22 12:50aiaustinSummaryLLoginService.cs login response has extra bool LibOMVClient for Radegast clients since avination merge causing add on errors => LLoginService.cs login response has extra bool LibOMVClient for Radegast clients since avination merge causing addon errors
2015-11-22 12:50aiaustinDescription Updatedbug_revision_view_page.php?rev_id=4879#r4879
2015-11-23 02:11aiaustinSummaryLLoginService.cs login response has extra bool LibOMVClient for Radegast clients since avination merge causing addon errors => LLoginService.cs login response has extra fields causing addon errors
2015-11-23 02:11aiaustinDescription Updatedbug_revision_view_page.php?rev_id=4882#r4882
2015-11-23 02:12aiaustinDescription Updatedbug_revision_view_page.php?rev_id=4883#r4883
2015-11-23 02:25aiaustinDescription Updatedbug_revision_view_page.php?rev_id=4884#r4884
2015-11-23 03:55aiaustinDescription Updatedbug_revision_view_page.php?rev_id=4885#r4885
2015-11-23 05:06aiaustinSummaryLLoginService.cs login response has extra fields causing addon errors => LLoginService.cs login response has extra fields causing addon errors, plus question on special Radegast handling
2015-11-23 05:06aiaustinDescription Updatedbug_revision_view_page.php?rev_id=4886#r4886
2015-11-23 15:54UbitUmarovNote Added: 0029616
2015-11-24 01:31aiaustinNote Added: 0029623
2015-11-24 01:39aiaustinNote Edited: 0029623bug_revision_view_page.php?bugnote_id=29623#r4905
2015-11-24 01:40aiaustinNote Edited: 0029623bug_revision_view_page.php?bugnote_id=29623#r4906
2015-11-24 01:40aiaustinNote Edited: 0029623bug_revision_view_page.php?bugnote_id=29623#r4907
2016-09-30 01:32cb-dtfNote Added: 0031166
2016-09-30 07:51UbitUmarovNote Added: 0031167
2018-08-27 04:39Fly-Man-Note Added: 0032896
2018-08-27 04:39Fly-Man-Statusnew => acknowledged

Notes
(0029616)
UbitUmarov   
2015-11-23 15:54   
Yes there are extra parameters.
(0029623)
aiaustin   
2015-11-24 01:31   
(edited on: 2015-11-24 01:40)
I now see in other commits that the LibOMVclient parameter in LoginReponse is set and used in OpenSim/Server/Handlers/Login/LLLoginHandlers.cs

The special handling for Radegast (lack of proxy handling?) which I assume is needed is in OpenSim/Services/LLLoginService/LLLoginService.cs

(0031166)
cb-dtf   
2016-09-30 01:32   
How can it be that Radegast gets to have special handling?
If there indeed is a compatibility problem, should this not be handled by Radegast instead?

Who gets to decide what compatibility tweaks can be in the main source or not?
(0031167)
UbitUmarov   
2016-09-30 07:51   
the LibOMVclient detection is only used on a display message for log and console and it is not about Radegast. It is included because it may still be usefully for some grid admins, like it was for avination.

Opensim-devs decide what is include or not in opensim. That, and internal decision process is describe some where on our site. (sorry not going look for it now)
(0032896)
Fly-Man-   
2018-08-27 04:39   
The LibOMVClient parameter has nothing to do with Radegast but more with the LibOpenMetaverse client programs.

As Ubit already has explained, that value is always false unless you use a LibOMV client to connect to the grid in which the value will be true.