MantisBT - opensim
View Issue Details
0007746opensim[MISC] Compiling / Buildingpublic2015-11-20 13:522015-11-21 09:06
frost 
 
normalminoralways
patch includedopen 
master (dev code) 
 
019d057563e741833463cadd2beccdfe79d19ebe
Grid (Multiple Regions per Sim)
Other
Unknown
None
0007746: fix warnings introduced with avination merge
The avination merge left a fair number of compile-time warnings. Fix.
1. clone fresh repo
2. ./runprebuild.sh
3. nant
As discussed on the mailing list, creating issue and creating patches.
No tags attached.
patch 0001-0007746-remove-unused-private-member-m_ForeignImport.patch (1,446) 2015-11-20 14:13
http://opensimulator.org/mantis/file_download.php?file_id=4420&type=bug
patch 0002-0007746-remove-unused-private-members-from-Capabilit.patch (7,104) 2015-11-20 14:13
http://opensimulator.org/mantis/file_download.php?file_id=4421&type=bug
patch 0003-0007746-remove-unused-private-members-from-various-F.patch (8,696) 2015-11-20 14:14
http://opensimulator.org/mantis/file_download.php?file_id=4422&type=bug
patch 0004-LLClientView-clean-up-code-that-is-commented-out.patch (4,665) 2015-11-20 14:14
http://opensimulator.org/mantis/file_download.php?file_id=4423&type=bug
patch 0005-0007746-remove-unused-private-members.patch (5,558) 2015-11-20 14:14
http://opensimulator.org/mantis/file_download.php?file_id=4424&type=bug
patch 0006-0007746-remove-unused-private-members-from-EntityTra.patch (1,079) 2015-11-20 14:14
http://opensimulator.org/mantis/file_download.php?file_id=4425&type=bug
patch 0007-0007746-clean-up-using-statements-in-ITerrainModule.patch (791) 2015-11-20 14:14
http://opensimulator.org/mantis/file_download.php?file_id=4426&type=bug
patch 0008-0007746-remove-unused-private-members-from-files-und.patch (11,013) 2015-11-20 14:15
http://opensimulator.org/mantis/file_download.php?file_id=4427&type=bug
patch 0009-0007746-remove-unused-private-members-from-BulletSim.patch (7,827) 2015-11-20 14:15
http://opensimulator.org/mantis/file_download.php?file_id=4428&type=bug
patch 0010-0007746-remove-unused-variable-declaration-from-ODET.patch (1,184) 2015-11-20 14:15
http://opensimulator.org/mantis/file_download.php?file_id=4429&type=bug
patch 0011-0007746-remove-unused-variables-from-ScriptEngine-me.patch (2,952) 2015-11-20 14:15
http://opensimulator.org/mantis/file_download.php?file_id=4430&type=bug
patch 0012-0007746-remove-unused-variables-from-Services.patch (2,643) 2015-11-20 14:15
http://opensimulator.org/mantis/file_download.php?file_id=4431&type=bug
patch 0013-0007746-remove-unused-private-members-from-SmartThre.patch (2,865) 2015-11-20 14:15
http://opensimulator.org/mantis/file_download.php?file_id=4432&type=bug
Issue History
2015-11-20 13:52frostNew Issue
2015-11-20 14:13frostFile Added: 0001-0007746-remove-unused-private-member-m_ForeignImport.patch
2015-11-20 14:13frostFile Added: 0002-0007746-remove-unused-private-members-from-Capabilit.patch
2015-11-20 14:14frostFile Added: 0003-0007746-remove-unused-private-members-from-various-F.patch
2015-11-20 14:14frostFile Added: 0004-LLClientView-clean-up-code-that-is-commented-out.patch
2015-11-20 14:14frostFile Added: 0005-0007746-remove-unused-private-members.patch
2015-11-20 14:14frostFile Added: 0006-0007746-remove-unused-private-members-from-EntityTra.patch
2015-11-20 14:14frostFile Added: 0007-0007746-clean-up-using-statements-in-ITerrainModule.patch
2015-11-20 14:15frostFile Added: 0008-0007746-remove-unused-private-members-from-files-und.patch
2015-11-20 14:15frostFile Added: 0009-0007746-remove-unused-private-members-from-BulletSim.patch
2015-11-20 14:15frostFile Added: 0010-0007746-remove-unused-variable-declaration-from-ODET.patch
2015-11-20 14:15frostFile Added: 0011-0007746-remove-unused-variables-from-ScriptEngine-me.patch
2015-11-20 14:15frostFile Added: 0012-0007746-remove-unused-variables-from-Services.patch
2015-11-20 14:15frostFile Added: 0013-0007746-remove-unused-private-members-from-SmartThre.patch
2015-11-20 14:17frostNote Added: 0029591
2015-11-20 14:17frostStatusnew => patch included
2015-11-20 17:32UbitUmarovNote Added: 0029592

Notes
(0029591)
frost   
2015-11-20 14:17   
Attached 13 patches with the first low-hanging fruit. I clustered the patches a bit, hope that is ok. I can resubmit one big patch if required.
(0029592)
UbitUmarov   
2015-11-20 17:32   
Hi, thanks but please stop for now :( You are also removing comments, dead code, etc, and that needs to be checked case by case, even some unused variables are there waiting future use
You removed for example debug messages that we put back every time we need.
I can't apply patches like this automatically. I will use them as reference.
I did remove a few of those warnings, increasing the total reported by 2 ;)