MantisBT - opensim
View Issue Details
0006373opensim[REGION] OpenSim Corepublic2012-10-24 06:182014-07-29 13:41
orenh 
justincc 
normalminoralways
closedfixed 
master (dev code) 
master (dev code) 
fc666a0ddb60c129585b23625d470a67647155be
Grid (Multiple Regions per Sim)
ODE
Mono / Linux32
2.10
0006373: [PATCH] Prevent some rare errors when loading/saving OARs
These patches fix some errors that can occur when loading or saving OARs:

1) 0001-If-Save-OAR-IAR-times-out-while-waiting-for-assets-t.patch

It's possible to time-out while saving the assets of an OAR or IAR. When that happens we now call the callback that had been waiting for the assets to finish; previously the callback wasn't called.

2) 0001-Changed-locks-to-prevent-deadlocks-especially-during.patch

Added locking to prevent some rare multithreading errors. I have seen these errors when loading multi-region OARs.
No tags attached.
patch 0001-Changed-locks-to-prevent-deadlocks-especially-during.patch (8,488) 2012-10-24 06:18
http://opensimulator.org/mantis/file_download.php?file_id=3376&type=bug
patch 0001-If-Save-OAR-IAR-times-out-while-waiting-for-assets-t.patch (8,323) 2013-01-01 22:31
http://opensimulator.org/mantis/file_download.php?file_id=3430&type=bug
Issue History
2012-10-24 06:18orenhNew Issue
2012-10-24 06:18orenhStatusnew => assigned
2012-10-24 06:18orenhAssigned To => justincc
2012-10-24 06:18orenhFile Added: 0001-If-Save-OAR-IAR-times-out-while-waiting-for-assets-t.patch
2012-10-24 06:18orenhFile Added: 0001-Changed-locks-to-prevent-deadlocks-especially-during.patch
2012-10-24 06:18orenhStatusassigned => patch included
2012-12-16 06:36orenhNote Added: 0023269
2013-01-01 16:56justinccNote Added: 0023353
2013-01-01 22:31orenhFile Deleted: 0001-If-Save-OAR-IAR-times-out-while-waiting-for-assets-t.patch
2013-01-01 22:31orenhFile Added: 0001-If-Save-OAR-IAR-times-out-while-waiting-for-assets-t.patch
2013-01-01 22:32orenhNote Added: 0023355
2013-01-02 14:33justinccNote Added: 0023360
2013-01-02 14:33justinccStatuspatch included => resolved
2013-01-02 14:33justinccResolutionopen => fixed
2014-07-29 13:41chi11kenStatusresolved => closed

Notes
(0023269)
orenh   
2012-12-16 06:36   
Any updates about this patch? It fixed a real problem for me (albeit a rare one).
(0023353)
justincc   
2013-01-01 16:56   
Hi Oren. I looked through the first patch and I'm happy to apply. However, the code has changed enough since October that it no longer applies cleanly. Please could you update it?

I hope to look through the second patch very soon but have run out of time today.
(0023355)
orenh   
2013-01-01 22:32   
I have uploaded a new version of the file: "0001-If-Save-OAR-IAR-times-out-while-waiting-for-assets-t.patch". It applies cleanly on today's git master.
(0023360)
justincc   
2013-01-02 14:33   
* If-Save-OAR-IAR... patch applied to git master as d24ca0d.

* Changed-locks-to-prevent... patch applied to git master as 9784e4e.

Thanks Oren.